Re: [Qemu-devel] [PATCH v5 06/46] qapi: Improve 'include' error message

2015-09-24 Thread Eric Blake
On 09/24/2015 08:39 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Use of '"...%s" % include' to print non-strings can lead to >> ugly messages, such as this (if the .json change is applied >> without the qapi.py change): >> Expected a file name (string), got: OrderedDict() >> >> Better

Re: [Qemu-devel] [PATCH v5 06/46] qapi: Improve 'include' error message

2015-09-24 Thread Markus Armbruster
Eric Blake writes: > Use of '"...%s" % include' to print non-strings can lead to > ugly messages, such as this (if the .json change is applied > without the qapi.py change): > Expected a file name (string), got: OrderedDict() > > Better is to just omit the actual non-string value in the > messag

[Qemu-devel] [PATCH v5 06/46] qapi: Improve 'include' error message

2015-09-21 Thread Eric Blake
Use of '"...%s" % include' to print non-strings can lead to ugly messages, such as this (if the .json change is applied without the qapi.py change): Expected a file name (string), got: OrderedDict() Better is to just omit the actual non-string value in the message. Signed-off-by: Eric Blake ---