Re: [Qemu-devel] [PATCH v5 06/14] qapi-event: Slightly shrink generated code

2016-03-19 Thread Markus Armbruster
Eric Blake writes: > Slightly rearrange the code in gen_event_send() for less generated > output, by initializing 'emit' sooner, deferring an assertion > to qdict_put_obj, and dropping a now-unused 'obj' local variable. > > While at it, document a FIXME related to the potential for a > compiler n

Re: [Qemu-devel] [PATCH v5 06/14] qapi-event: Slightly shrink generated code

2016-03-10 Thread Eric Blake
On 03/10/2016 11:50 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Slightly rearrange the code in gen_event_send() for less generated >> output, by initializing 'emit' sooner, deferring an assertion >> to qdict_put_obj, and dropping a now-unused 'obj' local variable. >> >> While at it, do

Re: [Qemu-devel] [PATCH v5 06/14] qapi-event: Slightly shrink generated code

2016-03-10 Thread Markus Armbruster
Eric Blake writes: > Slightly rearrange the code in gen_event_send() for less generated > output, by initializing 'emit' sooner, deferring an assertion > to qdict_put_obj, and dropping a now-unused 'obj' local variable. > > While at it, document a FIXME related to the potential for a > compiler n

[Qemu-devel] [PATCH v5 06/14] qapi-event: Slightly shrink generated code

2016-03-09 Thread Eric Blake
Slightly rearrange the code in gen_event_send() for less generated output, by initializing 'emit' sooner, deferring an assertion to qdict_put_obj, and dropping a now-unused 'obj' local variable. While at it, document a FIXME related to the potential for a compiler naming collision - if the user ev