Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-10 Thread Igor Mammedov
On Thu, 9 Feb 2017 12:39:30 -0800 Ben Warren wrote: > > On Feb 9, 2017, at 12:24 PM, Laszlo Ersek wrote: > > > > On 02/09/17 21:02, Ben Warren wrote: > >> > >>> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek >>> > wrote: > >>> > >>> On 02/09/17 18:23, Igor Mammedov w

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Ben Warren
> On Feb 9, 2017, at 12:24 PM, Laszlo Ersek wrote: > > On 02/09/17 21:02, Ben Warren wrote: >> >>> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek >> > wrote: >>> >>> On 02/09/17 18:23, Igor Mammedov wrote: On Wed, 8 Feb 2017 01:48:42 +0100 Laszlo Ersek mailto:ler

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Laszlo Ersek
On 02/09/17 21:02, Ben Warren wrote: > >> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek > > wrote: >> >> On 02/09/17 18:23, Igor Mammedov wrote: >>> On Wed, 8 Feb 2017 01:48:42 +0100 >>> Laszlo Ersek mailto:ler...@redhat.com>> wrote: >>> On 02/05/17 10:12, b...@skyportsy

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Ben Warren
> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek wrote: > > On 02/09/17 18:23, Igor Mammedov wrote: >> On Wed, 8 Feb 2017 01:48:42 +0100 >> Laszlo Ersek wrote: >> >>> On 02/05/17 10:12, b...@skyportsystems.com wrote: From: Ben Warren >> [...] >> >>> (2) Structure of the vmgenid fw_cfg blob,

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Laszlo Ersek
On 02/09/17 18:23, Igor Mammedov wrote: > On Wed, 8 Feb 2017 01:48:42 +0100 > Laszlo Ersek wrote: > >> On 02/05/17 10:12, b...@skyportsystems.com wrote: >>> From: Ben Warren > [...] > >> (2) Structure of the vmgenid fw_cfg blob, AKA "why that darn offset 40 >> decimal". >> >> I explained it und

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Michael S. Tsirkin
On Thu, Feb 09, 2017 at 06:23:16PM +0100, Igor Mammedov wrote: > On Wed, 8 Feb 2017 01:48:42 +0100 > Laszlo Ersek wrote: > > > On 02/05/17 10:12, b...@skyportsystems.com wrote: > > > From: Ben Warren > [...] > > > (2) Structure of the vmgenid fw_cfg blob, AKA "why that darn offset 40 > > decima

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Igor Mammedov
On Wed, 8 Feb 2017 01:48:42 +0100 Laszlo Ersek wrote: > On 02/05/17 10:12, b...@skyportsystems.com wrote: > > From: Ben Warren [...] > (2) Structure of the vmgenid fw_cfg blob, AKA "why that darn offset 40 > decimal". > > I explained it under points (6) and (7) in the following message: > > M

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Igor Mammedov
On Wed, 8 Feb 2017 12:19:24 -0800 Ben Warren wrote: > Thanks for reviewing Igor. > > > On Feb 7, 2017, at 5:48 AM, Igor Mammedov wrote: > > > > On Sun, 5 Feb 2017 01:12:00 -0800 > > b...@skyportsystems.com wrote: > > > >> From: Ben Warren > >> > >> This imp

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Laszlo Ersek
On 02/05/17 10:12, b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user interface is a simple device with

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Laszlo Ersek
On 02/08/17 23:34, Ben Warren wrote: > >> On Feb 7, 2017, at 4:48 PM, Laszlo Ersek > > wrote: >> >> On 02/05/17 10:12, b...@skyportsystems.com >> wrote: >>> From: Ben Warren mailto:b...@skyportsystems.com>> >>> >>> This implements the VM G

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Ben Warren
> On Feb 7, 2017, at 4:48 PM, Laszlo Ersek wrote: > > On 02/05/17 10:12, b...@skyportsystems.com > wrote: >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a fw_cfg blob. >> Any time the GUID c

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Ben Warren
Thanks for reviewing Igor. > On Feb 7, 2017, at 5:48 AM, Igor Mammedov wrote: > > On Sun, 5 Feb 2017 01:12:00 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the g

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Igor Mammedov
On Wed, 8 Feb 2017 12:17:54 +0100 Laszlo Ersek wrote: > On 02/08/17 12:04, Igor Mammedov wrote: > > On Wed, 8 Feb 2017 01:48:42 +0100 > > Laszlo Ersek wrote: > > [snip] > > >> (2) Structure of the vmgenid fw_cfg blob, AKA "why that darn offset 40 > >> decimal". > >> > >> I explained it under

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Laszlo Ersek
On 02/08/17 12:04, Igor Mammedov wrote: > On Wed, 8 Feb 2017 01:48:42 +0100 > Laszlo Ersek wrote: [snip] >> (2) Structure of the vmgenid fw_cfg blob, AKA "why that darn offset 40 >> decimal". >> >> I explained it under points (6) and (7) in the following message: >> >> Message-Id: >> URL: https

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Igor Mammedov
On Wed, 8 Feb 2017 01:48:42 +0100 Laszlo Ersek wrote: > On 02/05/17 10:12, b...@skyportsystems.com wrote: > > From: Ben Warren > > > > This implements the VM Generation ID feature by passing a 128-bit > > GUID to the guest via a fw_cfg blob. > > Any time the GUID changes, an ACPI notify event i

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-07 Thread Laszlo Ersek
On 02/05/17 10:12, b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user interface is a simple device with

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2017 at 05:04:56PM +0100, Igor Mammedov wrote: > On Tue, 7 Feb 2017 17:35:19 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Feb 07, 2017 at 03:00:32PM +0100, Igor Mammedov wrote: > > > On Mon, 6 Feb 2017 19:41:36 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon, F

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-07 Thread Igor Mammedov
On Tue, 7 Feb 2017 17:35:19 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 07, 2017 at 03:00:32PM +0100, Igor Mammedov wrote: > > On Mon, 6 Feb 2017 19:41:36 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Feb 06, 2017 at 09:29:30AM -0800, Ben Warren wrote: > > > > > > > > On Feb

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2017 at 03:00:32PM +0100, Igor Mammedov wrote: > On Mon, 6 Feb 2017 19:41:36 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Feb 06, 2017 at 09:29:30AM -0800, Ben Warren wrote: > > > > > > On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin > > > wrote: > > > > > > On Sun

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2017 at 02:48:22PM +0100, Igor Mammedov wrote: > On Sun, 5 Feb 2017 01:12:00 -0800 > b...@skyportsystems.com wrote: > > > From: Ben Warren > > > > This implements the VM Generation ID feature by passing a 128-bit > > GUID to the guest via a fw_cfg blob. > > Any time the GUID cha

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-07 Thread Igor Mammedov
On Mon, 6 Feb 2017 19:41:36 +0200 "Michael S. Tsirkin" wrote: > On Mon, Feb 06, 2017 at 09:29:30AM -0800, Ben Warren wrote: > > > > On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin wrote: > > > > On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.com wrote: > > > > Fr

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-07 Thread Igor Mammedov
On Sun, 5 Feb 2017 01:12:00 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user interface is a si

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 11:04 AM, Michael S. Tsirkin wrote: > > On Mon, Feb 06, 2017 at 10:48:05AM -0800, Ben Warren wrote: >> >>> On Feb 6, 2017, at 10:17 AM, Michael S. Tsirkin wrote: >>> >>> On Mon, Feb 06, 2017 at 09:59:55AM -0800, Ben Warren wrote: +void vmgenid_add_fw_cfg

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Michael S. Tsirkin
On Mon, Feb 06, 2017 at 10:48:05AM -0800, Ben Warren wrote: > > > On Feb 6, 2017, at 10:17 AM, Michael S. Tsirkin wrote: > > > > On Mon, Feb 06, 2017 at 09:59:55AM -0800, Ben Warren wrote: > >> +void vmgenid_add_fw_cfg(FWCfgState *s, GArray *guid) > >> +{ > >>

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 10:17 AM, Michael S. Tsirkin wrote: > > On Mon, Feb 06, 2017 at 09:59:55AM -0800, Ben Warren wrote: >> +void vmgenid_add_fw_cfg(FWCfgState *s, GArray *guid) >> +{ >> +Object *obj = find_vmgenid_dev(NULL); >> +as

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Michael S. Tsirkin
On Mon, Feb 06, 2017 at 09:59:55AM -0800, Ben Warren wrote: >+void vmgenid_add_fw_cfg(FWCfgState *s, GArray *guid) >+{ >+Object *obj = find_vmgenid_dev(NULL); >+assert(obj); >+VmGenIdState *vms = VMGENID(obj

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Michael S. Tsirkin
On Mon, Feb 06, 2017 at 09:29:30AM -0800, Ben Warren wrote: > > On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin wrote: > > On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.com wrote: > > From: Ben Warren > > This implements the VM Generation ID feature by p

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 9:41 AM, Michael S. Tsirkin wrote: > > On Mon, Feb 06, 2017 at 09:29:30AM -0800, Ben Warren wrote: >> >>On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin wrote: >> >>On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.com wrote: >> >>From: Ben Warr

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin wrote: > > On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.com > wrote: >> From: Ben Warren mailto:b...@skyportsystems.com>> >> >> This implements the VM Generation ID feature by passing a 128-bit >

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Michael S. Tsirkin
On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user interface i

[Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-05 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must be "auto" or in UUID format