Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-07 Thread Laszlo Ersek
On 02/07/17 13:11, Igor Mammedov wrote: > On Mon, 6 Feb 2017 19:31:24 +0200 > "Michael S. Tsirkin" wrote: > >> On Mon, Feb 06, 2017 at 09:16:25AM -0800, Ben Warren wrote: > @@ -257,8 +263,11 @@ void bios_linker_loader_add_pointer(BIOSLinker > *linker, > const BiosLinkerFileEntry

Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-07 Thread Igor Mammedov
On Mon, 6 Feb 2017 19:31:24 +0200 "Michael S. Tsirkin" wrote: > On Mon, Feb 06, 2017 at 09:16:25AM -0800, Ben Warren wrote: > > >> @@ -257,8 +263,11 @@ void bios_linker_loader_add_pointer(BIOSLinker > > >> *linker, > > >> const BiosLinkerFileEntry *source_file = > > >> bios_linker_fi

Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-06 Thread Michael S. Tsirkin
On Mon, Feb 06, 2017 at 09:16:25AM -0800, Ben Warren wrote: > >> @@ -257,8 +263,11 @@ void bios_linker_loader_add_pointer(BIOSLinker > >> *linker, > >> const BiosLinkerFileEntry *source_file = > >> bios_linker_find_file(linker, src_file); > >> > >> -assert(dst_patched_offset < dst

Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 6:56 AM, Michael S. Tsirkin wrote: > > On Sun, Feb 05, 2017 at 01:11:57AM -0800, b...@skyportsystems.com wrote: >> From: Ben Warren >> >> This adds to the existing 'add pointer' functionality in that it >> instructs the guest (BIOS or UEFI) to not patch memory but to inste

Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-06 Thread Michael S. Tsirkin
On Sun, Feb 05, 2017 at 01:11:57AM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > This adds to the existing 'add pointer' functionality in that it > instructs the guest (BIOS or UEFI) to not patch memory but to instead > write the changes back to QEMU via a writeable fw_cfg file. >

[Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-05 Thread ben
From: Ben Warren This adds to the existing 'add pointer' functionality in that it instructs the guest (BIOS or UEFI) to not patch memory but to instead write the changes back to QEMU via a writeable fw_cfg file. Signed-off-by: Ben Warren --- hw/acpi/aml-build.c | 2 +- hw/acp