Re: [Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-11 Thread John Snow
On 10/11/2017 04:42 AM, Kevin Wolf wrote: > Am 10.10.2017 um 21:24 hat John Snow geschrieben: >> >> >> On 10/10/2017 03:00 PM, Eric Blake wrote: >>> On 10/10/2017 09:43 AM, Eric Blake wrote: >>> >> --- >> v5: use second label for cleaner exit logic [John], use local_pnum >> @@ -1

Re: [Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-11 Thread Kevin Wolf
Am 10.10.2017 um 21:24 hat John Snow geschrieben: > > > On 10/10/2017 03:00 PM, Eric Blake wrote: > > On 10/10/2017 09:43 AM, Eric Blake wrote: > > > --- > v5: use second label for cleaner exit logic [John], use local_pnum > >> > @@ -1811,16 +1811,19 @@ static int64_t coroutine_fn

Re: [Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-10 Thread John Snow
On 10/10/2017 03:00 PM, Eric Blake wrote: > On 10/10/2017 09:43 AM, Eric Blake wrote: > --- v5: use second label for cleaner exit logic [John], use local_pnum >> @@ -1811,16 +1811,19 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs, int6

Re: [Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-10 Thread Eric Blake
On 10/10/2017 09:43 AM, Eric Blake wrote: >>> --- >>> v5: use second label for cleaner exit logic [John], use local_pnum > >>> @@ -1811,16 +1811,19 @@ static int64_t coroutine_fn >>> bdrv_co_get_block_status(BlockDriverState *bs, >>> int64_t total_sectors; >>> int64_t n; >>> int64

Re: [Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-10 Thread Eric Blake
On 10/10/2017 08:59 AM, Kevin Wolf wrote: > Am 04.10.2017 um 04:00 hat Eric Blake geschrieben: >> Not all callers care about which BDS owns the mapping for a given >> range of the file. This patch merely simplifies the callers by >> consolidating the logic in the common call point, while guarantee

Re: [Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-10 Thread Kevin Wolf
Am 04.10.2017 um 04:00 hat Eric Blake geschrieben: > Not all callers care about which BDS owns the mapping for a given > range of the file. This patch merely simplifies the callers by > consolidating the logic in the common call point, while guaranteeing > a non-NULL file to all the driver callbac

[Qemu-devel] [PATCH v5 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-10-03 Thread Eric Blake
Not all callers care about which BDS owns the mapping for a given range of the file. This patch merely simplifies the callers by consolidating the logic in the common call point, while guaranteeing a non-NULL file to all the driver callbacks, for no semantic change. The only caller that does not c