Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-14 Thread Stefan Hajnoczi
On Tue, Jan 13, 2015 at 08:07:15PM +0100, Christian Borntraeger wrote: > Am 13.01.2015 um 17:04 schrieb Stefan Hajnoczi: > [...] > > I'm really starting to get worried that you are going to break things. > > This DASD hack is a layering violation but okay, go ahead if you want. > > But now you are

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-13 Thread Christian Borntraeger
Am 13.01.2015 um 17:04 schrieb Stefan Hajnoczi: [...] > I'm really starting to get worried that you are going to break things. > This DASD hack is a layering violation but okay, go ahead if you want. > But now you are also thinking about breaking live migration. > > The proper thing to do is to in

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-13 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Jan 13, 2015 at 11:51:51AM +0100, Markus Armbruster wrote: >> Christian Borntraeger writes: >> >> > Am 02.01.2015 um 13:57 schrieb Stefan Hajnoczi: >> >> On Thu, Dec 18, 2014 at 04:59:50PM +0100, Christian Borntraeger wrote: >> >>> Are you ok with the patches?

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-13 Thread Stefan Hajnoczi
On Tue, Jan 13, 2015 at 11:51:51AM +0100, Markus Armbruster wrote: > Christian Borntraeger writes: > > > Am 02.01.2015 um 13:57 schrieb Stefan Hajnoczi: > >> On Thu, Dec 18, 2014 at 04:59:50PM +0100, Christian Borntraeger wrote: > >>> Are you ok with the patches? If yes, can you take care of thes

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-13 Thread Markus Armbruster
Christian Borntraeger writes: > Am 02.01.2015 um 13:57 schrieb Stefan Hajnoczi: >> On Thu, Dec 18, 2014 at 04:59:50PM +0100, Christian Borntraeger wrote: >>> Are you ok with the patches? If yes, can you take care of these >>> patches in the block tree? >> >> This series looks close, I've left co

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-13 Thread Ekaterina Tumanova
On 01/02/2015 02:30 PM, Stefan Hajnoczi wrote: On Thu, Dec 18, 2014 at 12:17:59PM +0100, Ekaterina Tumanova wrote: Updates v4 -> v5: Minor Updates according the last review from Markus: 1. update commit message for patch 2 2. fix comment typos 3. fix check_for_dasd to return -1 instead of -ENOT

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-13 Thread Christian Borntraeger
Am 02.01.2015 um 13:57 schrieb Stefan Hajnoczi: > On Thu, Dec 18, 2014 at 04:59:50PM +0100, Christian Borntraeger wrote: >> Are you ok with the patches? If yes, can you take care of these patches in >> the block tree? > > This series looks close, I've left comments on the patches. OK, so you wou

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-02 Thread Stefan Hajnoczi
On Thu, Dec 18, 2014 at 04:59:50PM +0100, Christian Borntraeger wrote: > Are you ok with the patches? If yes, can you take care of these patches in > the block tree? This series looks close, I've left comments on the patches. The series is fine for command-line QEMU users where probing makes the

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-02 Thread Stefan Hajnoczi
On Thu, Dec 18, 2014 at 12:17:59PM +0100, Ekaterina Tumanova wrote: > Updates v4 -> v5: > > Minor Updates according the last review from Markus: > 1. update commit message for patch 2 > 2. fix comment typos > 3. fix check_for_dasd to return -1 instead of -ENOTSUP > > Thanks, > Kate. > >

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2014-12-18 Thread Christian Borntraeger
Am 18.12.2014 um 12:17 schrieb Ekaterina Tumanova: > Updates v4 -> v5: > > Minor Updates according the last review from Markus: > 1. update commit message for patch 2 > 2. fix comment typos > 3. fix check_for_dasd to return -1 instead of -ENOTSUP > > Thanks, > Kate. > > -

[Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2014-12-18 Thread Ekaterina Tumanova
Updates v4 -> v5: Minor Updates according the last review from Markus: 1. update commit message for patch 2 2. fix comment typos 3. fix check_for_dasd to return -1 instead of -ENOTSUP Thanks, Kate. --- Patchset Description (didn't ch