Re: [Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Markus Armbruster
Alex Bennée writes: > Laszlo Ersek writes: > >> On 03/05/19 16:33, Markus Armbruster wrote: >>> You neglected to cc: the maintainers of hw/block, I fixed that for you. >>> >>> Alex Bennée writes: >>> It looks like there was going to be code to check we had some sort of alignment so le

Re: [Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Alex Bennée
Laszlo Ersek writes: > On 03/05/19 16:33, Markus Armbruster wrote: >> You neglected to cc: the maintainers of hw/block, I fixed that for you. >> >> Alex Bennée writes: >> >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual c

Re: [Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-03-07 Thread Markus Armbruster
One more thing... Alex Bennée writes: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the number of byt

Re: [Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-03-05 Thread Laszlo Ersek
On 03/05/19 16:33, Markus Armbruster wrote: > You neglected to cc: the maintainers of hw/block, I fixed that for you. > > Alex Bennée writes: > >> It looks like there was going to be code to check we had some sort of >> alignment so lets replace it with an actual check. This is a bit more >> use

Re: [Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-03-05 Thread Markus Armbruster
You neglected to cc: the maintainers of hw/block, I fixed that for you. Alex Bennée writes: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flas

Re: [Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-02-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190227111347.15063-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190227111347.15063-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v5] hw/block: better

[Qemu-devel] [PATCH v5] hw/block: better reporting on pflash backing file mismatch

2019-02-27 Thread Alex Bennée
It looks like there was going to be code to check we had some sort of alignment so lets replace it with an actual check. This is a bit more useful than the enigmatic "failed to read the initial flash content" when we attempt to read the number of bytes the device should have. This is a potential c