Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-14 Thread Richard Henderson
On 09/14/2016 01:56 AM, Paolo Bonzini wrote: >> I was hoping to avoid an extra RELATIVE relocation in the (normal) PIE >> case. > > There would be no relocation for 0 and NULL, right? GCC would actually > put them in bss, IIRC. Ah, I now see your complaint. You'd prefer "type var = INIT" over "

Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 03:11, Richard Henderson wrote: > On 09/13/2016 04:21 PM, Paolo Bonzini wrote: >> >> >> On 13/09/2016 22:57, Richard Henderson wrote: >>> -#if defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && >>> defined(__SSE2__)) >>> -#include >>> - >>> +#if (defined(CONFIG_AVX2_OPT) && de

Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-13 Thread Richard Henderson
On 09/13/2016 04:21 PM, Paolo Bonzini wrote: On 13/09/2016 22:57, Richard Henderson wrote: -#if defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && defined(__SSE2__)) -#include - +#if (defined(CONFIG_AVX2_OPT) && defined(CONFIG_CPUID_H)) || defined(__SSE2__) Your __SSE2__ version is bet

Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 22:57, Richard Henderson wrote: > -#if defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && > defined(__SSE2__)) > -#include > - > +#if (defined(CONFIG_AVX2_OPT) && defined(CONFIG_CPUID_H)) || > defined(__SSE2__) Your __SSE2__ version is better than mine which required cpuid.

[Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-13 Thread Richard Henderson
Handle alignment of buffers, so that the vector paths can be used more often. Signed-off-by: Richard Henderson Signed-off-by: Paolo Bonzini --- util/bufferiszero.c | 236 1 file changed, 162 insertions(+), 74 deletions(-) Tested with Fedora