Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-01 Thread Programmingkid
> On Feb 1, 2018, at 7:16 AM, BALATON Zoltan wrote: > > On Wed, 31 Jan 2018, Programmingkid wrote: Basically there is a array that acts as a check list. It checks off keys that belong to the ungrab sequence as they are detected. Once a non-ungrab key is detected, the check list is

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-01 Thread BALATON Zoltan
On Wed, 31 Jan 2018, Programmingkid wrote: Basically there is a array that acts as a check list. It checks off keys that belong to the ungrab sequence as they are detected. Once a non-ungrab key is detected, the check list is cleared. If all the ungrab keys are detected the ungrab code is execute

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-01 Thread Gerd Hoffmann
Hi, > > Well, the modifier key changes are actually sent to the guest, but > > usually they have no effect there. > > > > So, if you press Ctrl-Alt-F, the guest will see the keydown and keyup > > events for ctrl and alt. It will not see the 'f', because SDL hijacks > > that. > > Maybe the f c

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-31 Thread Programmingkid
> On Jan 31, 2018, at 4:03 AM, Gerd Hoffmann wrote: > >>> What about the other hotkeys? >>> >>> There is fullscreen. Ctrl-Alt-F for SDL and GTK. Cmd-F for cocoa, but >>> it works only if the grab is not active. >> >> If has to be that way because the meta (command) key is sent to the >> gues

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-31 Thread Gerd Hoffmann
> > What about the other hotkeys? > > > > There is fullscreen. Ctrl-Alt-F for SDL and GTK. Cmd-F for cocoa, but > > it works only if the grab is not active. > > If has to be that way because the meta (command) key is sent to the > guest when the mouse grab is in effect. I actually suggest the S

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-30 Thread Programmingkid
> On Jan 30, 2018, at 7:18 AM, Gerd Hoffmann wrote: > > On Fri, Jan 26, 2018 at 04:47:31PM -0500, John Arbuckle wrote: >> Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. > > SDL is the same now, for consistency. > >> This combination may not be very fun for the use

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-30 Thread Gerd Hoffmann
On Fri, Jan 26, 2018 at 04:47:31PM -0500, John Arbuckle wrote: > Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. SDL is the same now, for consistency. > This combination may not be very fun for the user to have to enter, so we > now enable the user to specify their ow

[Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-26 Thread John Arbuckle
Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. This combination may not be very fun for the user to have to enter, so we now enable the user to specify their own key(s) as the ungrab key(s). The list of keys that can be used is found in the file qapi/ui.json under QKey