Re: [Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

2017-11-13 Thread Dou Liyang
Hi Michael, [...] Seems to cause build failures: /scm/qemu/numa.c:452:13: error: too many arguments to function ‘parse_numa_node’ parse_numa_node(ms, &node, NULL, NULL); Yes, commit cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier") removed a argument from the functi

Re: [Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

2017-11-13 Thread Michael S. Tsirkin
On Fri, Oct 27, 2017 at 11:15:54AM +0800, Dou Liyang wrote: > Linux and Windows need ACPI SRAT table to make memory hotplug work properly, > however currently QEMU doesn't create SRAT table if numa options aren't > present > on CLI. > > Which breaks both linux and windows guests in certain condit

[Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

2017-10-26 Thread Dou Liyang
Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without SRAT table at all