Re: [Qemu-devel] [PATCH v5++ 1/3] tcg/mips: implement goto_ptr

2017-05-02 Thread Aurelien Jarno
On 2017-05-02 18:21, Richard Henderson wrote: > On 04/30/2017 04:52 PM, Aurelien Jarno wrote: > > +/* jmp to the given host address (could be epilogue) */ > > +tcg_out_opc_reg(s, OPC_JR, 0, a0, 0); > > +tcg_out_nop(s); > > Any particular reason not to do the zeroing in the

Re: [Qemu-devel] [PATCH v5++ 1/3] tcg/mips: implement goto_ptr

2017-05-02 Thread Richard Henderson
On 04/30/2017 04:52 PM, Aurelien Jarno wrote: +/* jmp to the given host address (could be epilogue) */ +tcg_out_opc_reg(s, OPC_JR, 0, a0, 0); +tcg_out_nop(s); Any particular reason not to do the zeroing in the delay slot... +s->code_gen_epilogue = s->code_ptr; +

Re: [Qemu-devel] [PATCH v5++ 1/3] tcg/mips: implement goto_ptr

2017-05-01 Thread Philippe Mathieu-Daudé
On 04/30/2017 11:52 AM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno Reviewed-by: Philippe Mathieu-Daudé --- tcg/mips/tcg-target.h | 2 +- tcg/mips/tcg-target.inc.c | 13 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.h b/tcg/mi

[Qemu-devel] [PATCH v5++ 1/3] tcg/mips: implement goto_ptr

2017-04-30 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/mips/tcg-target.h | 2 +- tcg/mips/tcg-target.inc.c | 13 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h index e3240cfba7..d75cb63ed3 100644 --- a/tcg/mips/tcg-target.h +++ b/tcg