Re: [Qemu-devel] [PATCH v4 5/5] pci: Fold pci_get_bus_devfn() into its sole caller

2019-05-13 Thread Greg Kurz
On Mon, 13 May 2019 16:19:39 +1000 David Gibson wrote: > The only remaining caller of pci_get_bus_devfn() is pci_nic_init_nofail(), > itself an old compatibility function. Fold the two together to avoid > re-using the stale interface. > > While we're there replace the explicit fprintf()s with e

[Qemu-devel] [PATCH v4 5/5] pci: Fold pci_get_bus_devfn() into its sole caller

2019-05-12 Thread David Gibson
The only remaining caller of pci_get_bus_devfn() is pci_nic_init_nofail(), itself an old compatibility function. Fold the two together to avoid re-using the stale interface. While we're there replace the explicit fprintf()s with error_report(). Signed-off-by: David Gibson --- hw/pci/pci.c | 60