Re: [Qemu-devel] [PATCH v4 3/3] net/rocker: Convert to realize()

2017-05-21 Thread Markus Armbruster
Mao Zhongyi writes: > Hi, Markus > > On 05/19/2017 03:20 PM, Markus Armbruster wrote: >> Mao Zhongyi writes: >> >>> The rocker device still implements the old PCIDeviceClass .init() >>> instead of the new .realize(). All devices need to be converted to >>> .realize(). >>> >>> .init() reports err

Re: [Qemu-devel] [PATCH v4 3/3] net/rocker: Convert to realize()

2017-05-21 Thread Mao Zhongyi
Hi, Markus On 05/19/2017 03:20 PM, Markus Armbruster wrote: Mao Zhongyi writes: The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, nega

Re: [Qemu-devel] [PATCH v4 3/3] net/rocker: Convert to realize()

2017-05-19 Thread Markus Armbruster
Mao Zhongyi writes: > The rocker device still implements the old PCIDeviceClass .init() > instead of the new .realize(). All devices need to be converted to > .realize(). > > .init() reports errors with fprintf() and return 0 on success, negative > number on failure. Meanwhile, when -device rocke

[Qemu-devel] [PATCH v4 3/3] net/rocker: Convert to realize()

2017-05-17 Thread Mao Zhongyi
The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, negative number on failure. Meanwhile, when -device rocker fails, it first report a specif