Re: [Qemu-devel] [PATCH v4 27/38] vnc: Clean up error reporting in vnc_init_func()

2018-10-18 Thread Gerd Hoffmann
On Wed, Oct 17, 2018 at 10:26:51AM +0200, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. vnc_init_func() does that, and then fails without > setting an error. Its caller main(), via qemu_opts_foreach(), is fine > with it, but clean

[Qemu-devel] [PATCH v4 27/38] vnc: Clean up error reporting in vnc_init_func()

2018-10-17 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. vnc_init_func() does that, and then fails without setting an error. Its caller main(), via qemu_opts_foreach(), is fine with it, but clean it up anyway. While there, drop a "Failed to start VNC server: " error me