Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-08 Thread Avi Kivity
On 01/08/2012 01:19 PM, Andreas Färber wrote: > > > > Correct, and the memory core will flush the tlb, so all is well. > > Hm, I had grep'ed for tlb_flush in memory.* without a hit... > I would've assumed to find tlb_flush_all() somewhere. > It's at then end of cpu_register_physical_memory_log(),

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-08 Thread Andreas Färber
Am 08.01.2012 12:16, schrieb Avi Kivity: > On 01/07/2012 06:09 PM, Peter Maydell wrote: >> On 7 January 2012 04:40, Andreas Färber wrote: >>> I noticed you're dropping a comment about tlb_flush(). Is that because >>> it was dead code, or does the Memory API take care of it for us? >>> (I assume th

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-08 Thread Avi Kivity
On 01/07/2012 06:09 PM, Peter Maydell wrote: > On 7 January 2012 04:40, Andreas Färber wrote: > > I noticed you're dropping a comment about tlb_flush(). Is that because > > it was dead code, or does the Memory API take care of it for us? > > (I assume the former because memory_region_set_enabled()

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-07 Thread Peter Maydell
On 7 January 2012 04:40, Andreas Färber wrote: > I noticed you're dropping a comment about tlb_flush(). Is that because > it was dead code, or does the Memory API take care of it for us? > (I assume the former because memory_region_set_enabled() does not take a > CPUState* to operate on.) Arrangi

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-06 Thread Andreas Färber
Am 06.01.2012 19:58, schrieb Peter Maydell: > Use the new memory mutator API to simplify the flash remap code; > this allows us to drop the flash_mapped flag. > > Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber I noticed you're dropping a comment about tlb_flush(). Is that because it

[Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-06 Thread Peter Maydell
Use the new memory mutator API to simplify the flash remap code; this allows us to drop the flash_mapped flag. Signed-off-by: Peter Maydell --- hw/integratorcp.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp