Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread francisco iglesias
Hello again Alistair, Thank you very much for the review! The new lines will be added into the next version of the patch series (v5). Best regards, Francisco Iglesias On 27 Oct 2017 16:41, "Alistair Francis" wrote: > On Fri, Oct 27, 2017 at 2:48 PM, francisco iglesias > wrote: > > Good day Al

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 2:48 PM, francisco iglesias wrote: > Good day Alistair, > > Yes exactly! The qspi aliases on the soc (named "qspi%d") targets the spi > busses on the qspi dev (named "spi%d"). I did it this way in hope that the > code resembles how we connect the SST flashes to the standard

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread francisco iglesias
Good day Alistair, Yes exactly! The qspi aliases on the soc (named "qspi%d") targets the spi busses on the qspi dev (named "spi%d"). I did it this way in hope that the code resembles how we connect the SST flashes to the standard spi devices. Would you like me to do this in an other way or do you

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 11:17 AM, francisco iglesias wrote: > Dear alistair, > > Thank you for the review comments! I will update according them in the next > version of the patch series! About your question, I might have misunderstod, > but isn't the alias "qspi"? (s/"qspi{0,1}" -> s->qspi/"spi

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread francisco iglesias
Dear alistair, Thank you for the review comments! I will update according them in the next version of the patch series! About your question, I might have misunderstod, but isn't the alias "qspi"? (s/"qspi{0,1}" -> s->qspi/"spi{0,1}") Best regards, Francisco Iglesias On 27 Oct 2017 10:49, "Alist

Re: [Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-27 Thread Alistair Francis
On Fri, Oct 27, 2017 at 7:56 AM, Francisco Iglesias wrote: > Add support for the ZynqMP QSPI (consisting of the Generic QSPI and Legacy > QSPI) and connect Numonyx n25q512a11 flashes to it. > > Signed-off-by: Francisco Iglesias > --- > hw/arm/xlnx-zcu102.c | 23 +++ >

[Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-26 Thread Francisco Iglesias
Add support for the ZynqMP QSPI (consisting of the Generic QSPI and Legacy QSPI) and connect Numonyx n25q512a11 flashes to it. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-zcu102.c | 23 +++ hw/arm/xlnx-zynqmp.c | 24 include/hw/a