Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-12 Thread Cornelia Huck
On Thu, 11 Apr 2019 17:27:42 -0400 Eric Farman wrote: > On 4/10/19 10:59 PM, Eric Farman wrote: > > > > > > On 4/9/19 7:34 PM, Halil Pasic wrote: > >> On Mon, 8 Apr 2019 19:07:47 +0200 > > ...snip... > > >> I'm just running fio on a pass-through DASD and on some virto-blk disks > >> in pa

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-11 Thread Eric Farman
On 4/10/19 10:59 PM, Eric Farman wrote: On 4/9/19 7:34 PM, Halil Pasic wrote: On Mon, 8 Apr 2019 19:07:47 +0200 ...snip... I'm just running fio on a pass-through DASD and on some virto-blk disks in parallel. My QEMU is today's vfio-ccw-caps from your repo. I see stuff like this: qemu-g

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-10 Thread Eric Farman
On 4/9/19 7:34 PM, Halil Pasic wrote: On Mon, 8 Apr 2019 19:07:47 +0200 Cornelia Huck wrote: On Mon, 8 Apr 2019 13:02:12 -0400 Farhan Ali wrote: On 03/01/2019 04:38 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we sti

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-09 Thread Halil Pasic
On Mon, 8 Apr 2019 19:07:47 +0200 Cornelia Huck wrote: > On Mon, 8 Apr 2019 13:02:12 -0400 > Farhan Ali wrote: > > > On 03/01/2019 04:38 AM, Cornelia Huck wrote: > > > When we get a solicited interrupt, the start function may have > > > been cleared by a csch, but we still have a channel progra

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-08 Thread Eric Farman
On 4/8/19 1:07 PM, Cornelia Huck wrote: On Mon, 8 Apr 2019 13:02:12 -0400 Farhan Ali wrote: On 03/01/2019 04:38 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make it s

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-08 Thread Farhan Ali
On 04/08/2019 01:07 PM, Cornelia Huck wrote: On Mon, 8 Apr 2019 13:02:12 -0400 Farhan Ali wrote: On 03/01/2019 04:38 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-08 Thread Cornelia Huck
On Mon, 8 Apr 2019 13:02:12 -0400 Farhan Ali wrote: > On 03/01/2019 04:38 AM, Cornelia Huck wrote: > > When we get a solicited interrupt, the start function may have > > been cleared by a csch, but we still have a channel program > > structure allocated. Make it safe to call the cp accessors in >

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-08 Thread Farhan Ali
On 03/01/2019 04:38 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make it safe to call the cp accessors in any case, so we can call them unconditionally. While at it, als

[Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-03-01 Thread Cornelia Huck
When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make it safe to call the cp accessors in any case, so we can call them unconditionally. While at it, also make sure that functions called from other parts