Re: [Qemu-devel] [PATCH v4 1/4] Add moxie target code

2013-02-28 Thread Peter Maydell
On 28 February 2013 17:30, Anthony Green wrote: > On Thu, Feb 28, 2013 at 6:06 AM, Peter Maydell > wrote: >> On 27 February 2013 22:09, Anthony Green wrote: >>> +case 0x31: /* div.l */ >>> +{ >>> +int a = (opcode >> 4) & 0xf; >>> +int b = opco

Re: [Qemu-devel] [PATCH v4 1/4] Add moxie target code

2013-02-28 Thread Anthony Green
Peter - thanks for reviewing this. On Thu, Feb 28, 2013 at 6:06 AM, Peter Maydell wrote: > On 27 February 2013 22:09, Anthony Green wrote: >> +static const VMStateDescription vmstate_moxie_cpu = { >> +.name = "cpu", >> +.unmigratable = 1, >> +}; > > Since this is a new CPU it should just

Re: [Qemu-devel] [PATCH v4 1/4] Add moxie target code

2013-02-28 Thread Peter Maydell
On 27 February 2013 22:09, Anthony Green wrote: > +static const VMStateDescription vmstate_moxie_cpu = { > +.name = "cpu", > +.unmigratable = 1, > +}; Since this is a new CPU it should just go ahead and implement migration support. > +/* The dynamic value of the DELAY_SLOT_TRUE flag dete

Re: [Qemu-devel] [PATCH v4 1/4] Add moxie target code

2013-02-28 Thread Peter Maydell
On 28 February 2013 08:30, Richard Henderson wrote: > Looks good now. Except for the start/end TB thing, which is > lacking the icount calls, which will shortly be the hooks to > exit the TB due to interrupt as well. > > But I'll still give it the > > Reviewed-by: Richard Henderson > > since PMM

Re: [Qemu-devel] [PATCH v4 1/4] Add moxie target code

2013-02-28 Thread Richard Henderson
On 2013-02-27 14:09, Anthony Green wrote: + done_generating: +ctx.last_T0_store = NULL; +*tcg_ctx.gen_opc_ptr = INDEX_op_end; Looks good now. Except for the start/end TB thing, which is lacking the icount calls, which will shortly be the hooks to exit the TB due to interrupt as well.

[Qemu-devel] [PATCH v4 1/4] Add moxie target code

2013-02-27 Thread Anthony Green
Signed-off-by: Anthony Green --- target-moxie/Makefile.objs |2 + target-moxie/cpu.c | 177 target-moxie/cpu.h | 222 ++ target-moxie/helper.c | 100 + target-moxie/helper.h |6 + target-moxie/machine.c | 11 + target-moxie/mmu.c