Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-10-09 Thread Xiao Long Jiang
On 2016/9/29 下午11:23, Markus Armbruster wrote: Xiao Long Jiang writes: Hi, I have tested this patch on arch s390 system. It works fine. :-) May I credit your help by adding Tested-by: Xiao Long Jiang to the commit message? Just back from holiday. It would be great if you add that

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-10-05 Thread Christian Borntraeger
On 09/29/2016 05:23 PM, Markus Armbruster wrote: > Xiao Long Jiang writes: > >> Hi, >> >> I have tested this patch on arch s390 system. It works fine. :-) > > May I credit your help by adding > > Tested-by: Xiao Long Jiang > > to the commit message? China has a some holiday, so do not ex

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict' failed.", because the qdict i

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-09-29 Thread Markus Armbruster
Xiao Long Jiang writes: > Hi, > > I have tested this patch on arch s390 system. It works fine. :-) May I credit your help by adding Tested-by: Xiao Long Jiang to the commit message?

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-09-22 Thread Xiao Long Jiang
Hi, I have tested this patch on arch s390 system. It works fine. :-) On 2016/9/23 上午4:39, Marc-André Lureau wrote: Since commit ad739706bbadee49, user_creatable_add_type() expects to be given a qdict. However, if object-add is called without props, you reach the assert: "qemu/qom/object_interfa

[Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-09-22 Thread Marc-André Lureau
Since commit ad739706bbadee49, user_creatable_add_type() expects to be given a qdict. However, if object-add is called without props, you reach the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: Assertion `qdict' failed.", because the qdict isn't created in this case (it's opti