Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Marc-André Lureau
- Original Message - > On Sat, Sep 19, 2015 at 12:12:00PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Replace the generic vhost_call() by specific functions for each > > function call to help with type safety and changing arguments. > > > > Signed-off-

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Michael S. Tsirkin
On Sat, Sep 19, 2015 at 12:12:00PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > Signed-off-by: Marc-André Lureau OK but I would rather

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Michael S. Tsirkin
On Mon, Sep 21, 2015 at 09:33:04AM +0200, Thibaut Collet wrote: > > +static int vhost_reset_owner(struct vhost_dev *dev) > > +{ > > +VhostUserMsg msg = { > > +.request = VHOST_USER_RESET_OWNER, > > +.flags = VHOST_USER_VERSION, > > +}; > > + > > +vhost_user_write(dev, &m

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Thibaut Collet
On Sat, Sep 19, 2015 at 12:12 PM, wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > Signed-off-by: Marc-André Lureau > --- > hw/net/vhost_net.c| 12 +- > hw/

[Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-19 Thread marcandre . lureau
From: Marc-André Lureau Replace the generic vhost_call() by specific functions for each function call to help with type safety and changing arguments. Signed-off-by: Marc-André Lureau --- hw/net/vhost_net.c| 12 +- hw/scsi/vhost-scsi.c | 7 +- hw/virtio/vhost-ba