Re: [Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure

2016-11-07 Thread Cédric Le Goater
On 11/07/2016 09:26 AM, Olaf Hering wrote: > On Mon, Oct 03, Cédric Le Goater wrote: > >> +++ b/include/hw/ppc/pnv_xscom.h > >> +typedef struct PnvChip PnvChip; > > This causes a compile error with gcc 4.5.1: Ah yes. That happens with "old" compilers. I will remove the extra definition. Thank

Re: [Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure

2016-11-07 Thread Olaf Hering
On Mon, Oct 03, Cédric Le Goater wrote: > +++ b/include/hw/ppc/pnv_xscom.h > +typedef struct PnvChip PnvChip; This causes a compile error with gcc 4.5.1: ... [ 552s] In file included from /usr/src/packages/BUILD/qemu-20161104T092624.9226682/hw/ppc/pnv.c:29:0: [ 552s] /usr/src/packages/BUILD

Re: [Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure

2016-10-12 Thread Cédric Le Goater
On 10/13/2016 02:41 AM, David Gibson wrote: > On Mon, Oct 03, 2016 at 09:24:42AM +0200, Cédric Le Goater wrote: >> On a real POWER8 system, the Pervasive Interconnect Bus (PIB) serves >> as a backbone to connect different units of the system. The host >> firmware connects to the PIB through a bridg

Re: [Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure

2016-10-12 Thread David Gibson
On Mon, Oct 03, 2016 at 09:24:42AM +0200, Cédric Le Goater wrote: > On a real POWER8 system, the Pervasive Interconnect Bus (PIB) serves > as a backbone to connect different units of the system. The host > firmware connects to the PIB through a bridge unit, the > Alter-Display-Unit (ADU), which giv

[Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure

2016-10-03 Thread Cédric Le Goater
On a real POWER8 system, the Pervasive Interconnect Bus (PIB) serves as a backbone to connect different units of the system. The host firmware connects to the PIB through a bridge unit, the Alter-Display-Unit (ADU), which gives him access to all the chiplets on the PCB network (Pervasive Connect Bu