Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread Eric Blake
On 09/05/2018 08:09 AM, John Snow wrote: On 09/05/2018 06:43 AM, Max Reitz wrote: On 2018-09-04 19:09, John Snow wrote: For purposes of minimum code movement, refactor the mirror_exit callback to use the post-finalization callbacks in a trivial way. Signed-off-by: John Snow --- block/mirr

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread John Snow
On 09/05/2018 06:43 AM, Max Reitz wrote: > On 2018-09-04 19:09, John Snow wrote: >> For purposes of minimum code movement, refactor the mirror_exit >> callback to use the post-finalization callbacks in a trivial way. >> >> Signed-off-by: John Snow >> --- >> block/mirror.c | 34 +

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread Max Reitz
On 2018-09-04 19:09, John Snow wrote: > For purposes of minimum code movement, refactor the mirror_exit > callback to use the post-finalization callbacks in a trivial way. > > Signed-off-by: John Snow > --- > block/mirror.c | 34 +++--- > 1 file changed, 27 insertions

[Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-04 Thread John Snow
For purposes of minimum code movement, refactor the mirror_exit callback to use the post-finalization callbacks in a trivial way. Signed-off-by: John Snow --- block/mirror.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/block/mirror.c b/b