On 03/08/2016 09:11 AM, Eric Blake wrote:
>>>
>>> -ret += gen_visit_members(arg_type.members, skiperr=dealloc)
>>
>> Unless I'm mistaken, this is the only use of skiperr. Follow up with a
>> patch to drop the parameter and simplify?
>
> Oh, nice. I noticed some cleanups in patch 6/10, but m
Eric Blake writes:
> On 03/08/2016 11:09 AM, Markus Armbruster wrote:
>
>> This patch actually fixes a similar issue in the qmp_marshal_FOO()
>> functions.
>
> Indeed, and I didn't even realize it. I'll add that to the commit message :)
>
>>
>> To keep ignoring it in the qapi_event_send_BAR() fu
On 03/08/2016 11:09 AM, Markus Armbruster wrote:
> This patch actually fixes a similar issue in the qmp_marshal_FOO()
> functions.
Indeed, and I didn't even realize it. I'll add that to the commit message :)
>
> To keep ignoring it in the qapi_event_send_BAR() functions is okay.
> It's fairly e
Eric Blake writes:
> On 03/08/2016 08:10 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> Rather than generate inline per-member visits, take advantage
>>> of the 'visit_type_FOO_members()' function for both event and
>>> command marshalling. This is possible now that implicit
>>> str
On 03/08/2016 08:10 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Rather than generate inline per-member visits, take advantage
>> of the 'visit_type_FOO_members()' function for both event and
>> command marshalling. This is possible now that implicit
>> structs can be visited like any
Eric Blake writes:
> Rather than generate inline per-member visits, take advantage
> of the 'visit_type_FOO_members()' function for both event and
> command marshalling. This is possible now that implicit
> structs can be visited like any other.
>
> Generated code shrinks accordingly; events ini
Rather than generate inline per-member visits, take advantage
of the 'visit_type_FOO_members()' function for both event and
command marshalling. This is possible now that implicit
structs can be visited like any other.
Generated code shrinks accordingly; events initialize a struct
based on parame
