Re: [Qemu-devel] [PATCH v4 04/54] target/arm: remove run time semihosting checks

2019-08-01 Thread Richard Henderson
On 7/31/19 9:06 AM, Alex Bennée wrote: > -static inline bool check_for_semihosting(CPUState *cs) > +/* > + * Do semihosting call and set the appropriate return value. All the > + * permission and validity checks have been done at translate time. > + * > + * We only see semihosting exceptions in TCG

Re: [Qemu-devel] [PATCH v4 04/54] target/arm: remove run time semihosting checks

2019-08-01 Thread Peter Maydell
On Thu, 1 Aug 2019 at 14:27, Aaron Lindsay OS wrote: > > On Jul 31 17:06, Alex Bennée wrote: > > @@ -8371,11 +8315,13 @@ void arm_cpu_do_interrupt(CPUState *cs) > > return; > > } > > > > -/* Semihosting semantics depend on the register width of the > > - * code that caused t

Re: [Qemu-devel] [PATCH v4 04/54] target/arm: remove run time semihosting checks

2019-08-01 Thread Aaron Lindsay OS via Qemu-devel
On Jul 31 17:06, Alex Bennée wrote: > Now we do all our checking and use a common EXCP_SEMIHOST for > semihosting operations we can make helper code a lot simpler. > > Signed-off-by: Alex Bennée > > --- > v2 > - fix re-base conflicts > - hoist EXCP_SEMIHOST check > - comment cleanups > ---

[Qemu-devel] [PATCH v4 04/54] target/arm: remove run time semihosting checks

2019-07-31 Thread Alex Bennée
Now we do all our checking and use a common EXCP_SEMIHOST for semihosting operations we can make helper code a lot simpler. Signed-off-by: Alex Bennée --- v2 - fix re-base conflicts - hoist EXCP_SEMIHOST check - comment cleanups --- target/arm/helper.c | 90 +--