Re: [Qemu-devel] [PATCH v4 04/10] qapi: Emit implicit structs in generated C

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > On 03/08/2016 12:09 PM, Markus Armbruster wrote: > >> >>> I think what would sway me over the fence is looking at some of our >>> constructs: for example, qapi-types.py has gen_object() which it now >>> calls recursively. When called directly from visit_object_type(), we >>

Re: [Qemu-devel] [PATCH v4 04/10] qapi: Emit implicit structs in generated C

2016-03-08 Thread Eric Blake
On 03/08/2016 12:09 PM, Markus Armbruster wrote: > >> I think what would sway me over the fence is looking at some of our >> constructs: for example, qapi-types.py has gen_object() which it now >> calls recursively. When called directly from visit_object_type(), we >> have all the pieces; when c

Re: [Qemu-devel] [PATCH v4 04/10] qapi: Emit implicit structs in generated C

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > On 03/08/2016 07:24 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> We already have several places that want to visit all the members >>> of an implicit object within a larger context (simple union variant, >>> event with anonymous data, command with anonymous arg

Re: [Qemu-devel] [PATCH v4 04/10] qapi: Emit implicit structs in generated C

2016-03-08 Thread Eric Blake
On 03/08/2016 07:24 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We already have several places that want to visit all the members >> of an implicit object within a larger context (simple union variant, >> event with anonymous data, command with anonymous arguments struct); >> and will

Re: [Qemu-devel] [PATCH v4 04/10] qapi: Emit implicit structs in generated C

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > We already have several places that want to visit all the members > of an implicit object within a larger context (simple union variant, > event with anonymous data, command with anonymous arguments struct); > and will be adding another one soon (the ability to declare an > a

[Qemu-devel] [PATCH v4 04/10] qapi: Emit implicit structs in generated C

2016-03-05 Thread Eric Blake
We already have several places that want to visit all the members of an implicit object within a larger context (simple union variant, event with anonymous data, command with anonymous arguments struct); and will be adding another one soon (the ability to declare an anonymous base for a flat union)