Re: [Qemu-devel] [PATCH v4 03/24] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug

2018-09-30 Thread Auger Eric
Hi David, On 9/26/18 11:41 AM, David Hildenbrand wrote: > We're plugging/unplugging a PCDIMMDevice, so directly pass this type > instead of a more generic DeviceState. > > Signed-off-by: David Hildenbrand Reviewed-by: Eric Auger Thanks Eric > --- > hw/i386/pc.c | 6 +++--- > hw/

Re: [Qemu-devel] [PATCH v4 03/24] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug

2018-09-27 Thread David Hildenbrand
On 27/09/2018 09:40, Igor Mammedov wrote: > On Wed, 26 Sep 2018 11:41:58 +0200 > David Hildenbrand wrote: > >> We're plugging/unplugging a PCDIMMDevice, so directly pass this type >> instead of a more generic DeviceState. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/i386/pc.c

Re: [Qemu-devel] [PATCH v4 03/24] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug

2018-09-27 Thread Igor Mammedov
On Wed, 26 Sep 2018 11:41:58 +0200 David Hildenbrand wrote: > We're plugging/unplugging a PCDIMMDevice, so directly pass this type > instead of a more generic DeviceState. > > Signed-off-by: David Hildenbrand > --- > hw/i386/pc.c | 6 +++--- > hw/mem/pc-dimm.c | 16 +++

Re: [Qemu-devel] [PATCH v4 03/24] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug

2018-09-26 Thread David Gibson
On Wed, Sep 26, 2018 at 11:41:58AM +0200, David Hildenbrand wrote: > We're plugging/unplugging a PCDIMMDevice, so directly pass this type > instead of a more generic DeviceState. > > Signed-off-by: David Hildenbrand Seems type-safer than the previous version. Reviewed-by: David Gibson and ppc

[Qemu-devel] [PATCH v4 03/24] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug

2018-09-26 Thread David Hildenbrand
We're plugging/unplugging a PCDIMMDevice, so directly pass this type instead of a more generic DeviceState. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 6 +++--- hw/mem/pc-dimm.c | 16 +++- hw/ppc/spapr.c | 8 include/hw/mem/pc-dimm.h