Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-22 Thread Kevin Wolf
Am 22.11.2019 um 15:40 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 22.11.2019 um 08:29 hat Markus Armbruster geschrieben: > >> > At any rate, your counterpoint is taken - whatever we pick, we'll want > >> > to make sure that introspection can expose semantics, and whether we

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.11.2019 um 08:29 hat Markus Armbruster geschrieben: >> > At any rate, your counterpoint is taken - whatever we pick, we'll want >> > to make sure that introspection can expose semantics, and whether we >> > can make '*' redundant with some other form of longhand in the

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-22 Thread Kevin Wolf
Am 22.11.2019 um 08:29 hat Markus Armbruster geschrieben: > > At any rate, your counterpoint is taken - whatever we pick, we'll want > > to make sure that introspection can expose semantics, and whether we > > can make '*' redundant with some other form of longhand in the qapi > > language is in pa

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Markus Armbruster
Eric Blake writes: > On 11/21/19 1:46 PM, Markus Armbruster wrote: > The '*' is redundant in this form. Can anyone think of reasons for keeping it anyway? Against? >>> >>> Is there ever a reason to allow an optional member but without a >>> 'default' value? Or can we just blindly

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Eric Blake
On 11/21/19 1:46 PM, Markus Armbruster wrote: The '*' is redundant in this form. Can anyone think of reasons for keeping it anyway? Against? Is there ever a reason to allow an optional member but without a 'default' value? Or can we just blindly state that if 'default' is not present, that

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Markus Armbruster
Eric Blake writes: > On 11/21/19 9:07 AM, Markus Armbruster wrote: >> Max Reitz writes: >> >>> With this change, it is possible to give default values for struct >>> members, as follows: >>> >>>What you had to do so far: >>> >>> # @member: Some description, defaults to 42. >>> { 's

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Eric Blake
On 11/21/19 9:07 AM, Markus Armbruster wrote: Max Reitz writes: With this change, it is possible to give default values for struct members, as follows: What you had to do so far: # @member: Some description, defaults to 42. { 'struct': 'Foo', 'data': { '*member': 'int' }

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Markus Armbruster
Max Reitz writes: > With this change, it is possible to give default values for struct > members, as follows: > > What you had to do so far: > > # @member: Some description, defaults to 42. > { 'struct': 'Foo', > 'data': { '*member': 'int' } } > > What you can do now: > > {

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-14 Thread Markus Armbruster
Less than thorough review, because I expect the necessary rebase will require a bit of rewriting here and there. Max Reitz writes: > With this change, it is possible to give default values for struct > members, as follows: > > What you had to do so far: > > # @member: Some description, def

[Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-06-24 Thread Max Reitz
With this change, it is possible to give default values for struct members, as follows: What you had to do so far: # @member: Some description, defaults to 42. { 'struct': 'Foo', 'data': { '*member': 'int' } } What you can do now: { 'struct': 'Foo', 'data': { '*membe