Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-08-02 Thread Kevin Wolf
Am 01.08.2016 um 15:35 hat Alberto Garcia geschrieben: > On Thu 14 Jul 2016 03:28:05 PM CEST, Kevin Wolf wrote: > > -blk = blk_by_name(device); > > -if (!blk) { > > -error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, > > - "Device '%s' not found", device); > > +bs =

Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:05 PM CEST, Kevin Wolf wrote: > -blk = blk_by_name(device); > -if (!blk) { > -error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, > - "Device '%s' not found", device); > +bs = qmp_get_root_bs(device, &local_err); > +if (!bs) { > +b

Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-07-18 Thread Max Reitz
On 18.07.2016 18:13, Eric Blake wrote: > On 07/18/2016 07:38 AM, Max Reitz wrote: >> On 14.07.2016 15:28, Kevin Wolf wrote: >>> In order to remove the necessity to use BlockBackend names in the >>> external API, we want to allow node-names everywhere. This converts >>> block-commit to accept a node

Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-07-18 Thread Eric Blake
On 07/18/2016 07:38 AM, Max Reitz wrote: > On 14.07.2016 15:28, Kevin Wolf wrote: >> In order to remove the necessity to use BlockBackend names in the >> external API, we want to allow node-names everywhere. This converts >> block-commit to accept a node-name without lifting the restriction that >>

Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-07-18 Thread Max Reitz
On 14.07.2016 15:28, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-commit to accept a node-name without lifting the restriction that > we're operating at a root node. > > As libvir

Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-commit to accept a node-name without lifting the restriction that > we're operating at a root node. > > As lib

[Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-07-14 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-commit to accept a node-name without lifting the restriction that we're operating at a root node. As libvirt makes use of the DeviceNotFound error class, we m