Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-13 Thread Eric Blake
On 07/13/2017 06:22 AM, Markus Armbruster wrote: I can take this through my tree once PATCH 4 got some R-by from PC paintainers. Whom you again neglected to cc; I just did that for you. I'll be happy to touch up minor issues like the ones I pointed out for v4. >>> >>> Thanks fo

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-13 Thread Markus Armbruster
Eric Blake writes: > On 07/13/2017 02:08 AM, Alistair Francis wrote: >> On Wed, Jul 12, 2017 at 6:49 PM, Markus Armbruster wrote: >>> Alistair Francis writes: >>> QEMU currently has a standard method to report errors with error_repot(). This ensure a sane and standard format when prin

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-13 Thread Eric Blake
On 07/13/2017 02:08 AM, Alistair Francis wrote: > On Wed, Jul 12, 2017 at 6:49 PM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> QEMU currently has a standard method to report errors with >>> error_repot(). This ensure a sane and standard format when printing >>> errors. This series

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-13 Thread Alistair Francis
On Wed, Jul 12, 2017 at 6:49 PM, Markus Armbruster wrote: > Alistair Francis writes: > >> QEMU currently has a standard method to report errors with >> error_repot(). This ensure a sane and standard format when printing >> errors. This series is attempting to extend this functionality for >> warn

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-12 Thread Markus Armbruster
Alistair Francis writes: > QEMU currently has a standard method to report errors with > error_repot(). This ensure a sane and standard format when printing > errors. This series is attempting to extend this functionality for > warnings and information as well. > > This patch renames error_print_l

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1499866456.git.alistair.fran...@xilinx.com Subject: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

[Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-12 Thread Alistair Francis
QEMU currently has a standard method to report errors with error_repot(). This ensure a sane and standard format when printing errors. This series is attempting to extend this functionality for warnings and information as well. This patch renames error_print_loc() function to be more clear, but I