Re: [Qemu-devel] [PATCH v4] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-07 Thread Pierre Morel
On 09/07/2015 12:20 PM, Stefan Hajnoczi wrote: On Wed, Sep 02, 2015 at 06:53:44PM +0200, Pierre Morel wrote: +addr = virtio_queue_get_desc_addr(vdev, n); +size = virtio_queue_get_desc_size(vdev, n); +ptr = vring_map(&vring->mr_desc, addr, size, true); +if (!ptr) { +erro

Re: [Qemu-devel] [PATCH v4] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-07 Thread Stefan Hajnoczi
On Wed, Sep 02, 2015 at 06:53:44PM +0200, Pierre Morel wrote: > +addr = virtio_queue_get_desc_addr(vdev, n); > +size = virtio_queue_get_desc_size(vdev, n); > +ptr = vring_map(&vring->mr_desc, addr, size, true); > +if (!ptr) { > +error_report("Failed to map 0x%16lx byte for v

Re: [Qemu-devel] [PATCH v4] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-03 Thread Greg Kurz
On Wed, 2 Sep 2015 18:53:44 +0200 Pierre Morel wrote: > Let dataplane allocate different region for the desc/avail/used > ring regions. > Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail > rings accordingly. > > Signed-off-by: Pierre Morel > > --- Yet another remark, see

Re: [Qemu-devel] [PATCH v4] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-03 Thread Greg Kurz
On Wed, 2 Sep 2015 18:53:44 +0200 Pierre Morel wrote: > Let dataplane allocate different region for the desc/avail/used > ring regions. > Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail > rings accordingly. > > Signed-off-by: Pierre Morel > I'll re-run tests after people

[Qemu-devel] [PATCH v4] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-02 Thread Pierre Morel
Let dataplane allocate different region for the desc/avail/used ring regions. Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail rings accordingly. Signed-off-by: Pierre Morel --- Changes from V2: - incorporate the code directly in vring_setup(). - added room for the event inde