Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefan Hajnoczi
On Wed, Feb 13, 2019 at 06:45:20PM +0100, Stefano Garzarella wrote: > I'm not sure if using the feature_sizes array the migration works well. > I mean if we have QEMU 3.1 with a single queue and we want to migrate to > QEMU 4.0 with a single queue, the config_size could be different, > because VIRT

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefano Garzarella
On Wed, Feb 13, 2019 at 6:07 PM Michael S. Tsirkin wrote: > On Wed, Feb 13, 2019 at 01:17:03PM +0100, Stefano Garzarella wrote: > > > > In my series "[PATCH v4 0/6] virtio-blk: add DISCARD and WRITE_ZEROES" > > I'm adding the host_features field in VirtIOBlock. Then, I could add > > something like

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2019 at 01:17:03PM +0100, Stefano Garzarella wrote: > On Wed, Feb 13, 2019 at 09:32:27AM +0100, Stefano Garzarella wrote: > > On Wed, Feb 13, 2019 at 04:01:43PM +0800, Stefan Hajnoczi wrote: > > > On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > > > > Commit caa1ee43

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefano Garzarella
On Wed, Feb 13, 2019 at 09:32:27AM +0100, Stefano Garzarella wrote: > On Wed, Feb 13, 2019 at 04:01:43PM +0800, Stefan Hajnoczi wrote: > > On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > > > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > > > support" added fie

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefano Garzarella
On Wed, Feb 13, 2019 at 04:01:43PM +0800, Stefan Hajnoczi wrote: > On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > > support" added fields to struct virtio_blk_config. This changes > > the size of the config spa

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Greg Kurz
On Wed, 13 Feb 2019 09:48:57 +0800 Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > support" added fields to struct virtio_blk_config. This changes > the size of the config space and breaks migration from QEMU 3.1 > and older: > > qemu-system-ppc64: get

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefan Hajnoczi
On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > support" added fields to struct virtio_blk_config. This changes > the size of the config space and breaks migration from QEMU 3.1 > and older: > > qemu-system-ppc64

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-13 Thread Stefan Hajnoczi
On Tue, Feb 12, 2019 at 09:05:11PM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > > support" added fields to struct virtio_blk_config. This changes > > the size of the config

Re: [Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Michael S. Tsirkin
On Wed, Feb 13, 2019 at 09:48:57AM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features > support" added fields to struct virtio_blk_config. This changes > the size of the config space and breaks migration from QEMU 3.1 > and older: > > qemu-system-ppc64

[Qemu-devel] [PATCH v4] virtio-blk: set correct config size for the host driver

2019-02-12 Thread Changpeng Liu
Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" added fields to struct virtio_blk_config. This changes the size of the config space and breaks migration from QEMU 3.1 and older: qemu-system-ppc64: get_pci_config_device: Bad config data: i=0x10 read: 41 device: 1 cmask: