Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-13 Thread P J P
+-- On Thu, 13 Oct 2016, Peter Maydell wrote --+ | I suggest you try putting in some sample values for the | various variables to confirm that your new code produces the | same answers that the old code did. Yep, sent a revised patch v5. Thank you. -- Prasad J Pandit / Red Hat Product Security Tea

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-13 Thread Peter Maydell
On 13 October 2016 at 07:42, P J P wrote: > +-- On Wed, 12 Oct 2016, Peter Maydell wrote --+ > | > -while (gtb->compare < update.new) { > | > +if (gtb->compare < update.new) { > | > > | > +inc = update.new - gtb->compare - 1; > | > | Can you explain why

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-12 Thread P J P
+-- On Wed, 12 Oct 2016, Peter Maydell wrote --+ | > -while (gtb->compare < update.new) { | > +if (gtb->compare < update.new) { | > | > +inc = update.new - gtb->compare - 1; | | Can you explain why the '- 1' here ? I think I did that because while was

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-12 Thread Peter Maydell
On 8 October 2016 at 06:04, P J P wrote: > From: Prasad J Pandit > > ARM A9MP processor has a peripheral timer with an auto-increment > register, which holds an increment step value. A user could set > this value to zero. When auto-increment control bit is enabled, > it leads to an infinite loop

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-11 Thread Fam Zheng
On Tue, 10/11 22:44, P J P wrote: > +-- On Mon, 10 Oct 2016, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com > wrote --+ > | Your series failed automatic build test. Please find the testing commands > and > | their output below. If you have docker installed, you can probably > reproduce it > |

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-11 Thread P J P
+-- On Mon, 10 Oct 2016, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote --+ | Your series failed automatic build test. Please find the testing commands and | their output below. If you have docker installed, you can probably reproduce it | locally. I tried to build it locally(without

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-10 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1475903058-729-1-git-send-email-ppan...@redhat.com Subject: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop

[Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-07 Thread P J P
From: Prasad J Pandit ARM A9MP processor has a peripheral timer with an auto-increment register, which holds an increment step value. A user could set this value to zero. When auto-increment control bit is enabled, it leads to an infinite loop in 'a9_gtimer_update' while updating comparator value