Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-16 Thread Marc-André Lureau
On Fri, Aug 10, 2018 at 3:28 PM Eric Blake wrote: > > In kill_qemu() we have an assert that checks that the QEMU process > didn't dump core: > assert(!WCOREDUMP(wstatus)); > > Unfortunately the WCOREDUMP macro here means the resulting message > is not very easy to comprehend on at leas

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-15 Thread Eric Blake
On 08/15/2018 08:35 AM, Markus Armbruster wrote: /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death from signal 11 (Segmentation fault) (core dumped) Well, it would help if my commit message actually matched... +const char *dump = WCOREDUMP(wstatus) ?

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2018 10:35 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/13/2018 02:17 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> On 08/10/2018 08:28 AM, Eric Blake wrote: > Instead of using a raw assert, print the information in an > easier to understand way: >

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-15 Thread Markus Armbruster
Eric Blake writes: > On 08/13/2018 02:17 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/10/2018 08:28 AM, Eric Blake wrote: Instead of using a raw assert, print the information in an easier to understand way: /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-13 Thread Eric Blake
On 08/13/2018 02:17 AM, Markus Armbruster wrote: Eric Blake writes: On 08/10/2018 08:28 AM, Eric Blake wrote: Instead of using a raw assert, print the information in an easier to understand way: /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death from signal 11 (Segment

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-13 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2018 08:28 AM, Eric Blake wrote: >> Instead of using a raw assert, print the information in an >> easier to understand way: >> >> /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death >> from signal 11 (Segmentation fault) (core dumped) > > Well,

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-10 Thread Eric Blake
On 08/10/2018 08:28 AM, Eric Blake wrote: Instead of using a raw assert, print the information in an easier to understand way: /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death from signal 11 (Segmentation fault) (core dumped) Well, it would help if my commit message ac

[Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-10 Thread Eric Blake
In kill_qemu() we have an assert that checks that the QEMU process didn't dump core: assert(!WCOREDUMP(wstatus)); Unfortunately the WCOREDUMP macro here means the resulting message is not very easy to comprehend on at least some systems: ahci-test: tests/libqtest.c:113: kill_qemu: Ass