Re: [Qemu-devel] [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-08 Thread Kevin Wolf
Am 08.06.2010 06:39, schrieb MORITA Kazutaka: > At Fri, 4 Jun 2010 16:35:59 -0300, > Miguel Di Ciurcio Filho wrote: >> >> Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. >> >> First issue: Their names implies different porpouses, but they do the same >> thing >> and

Re: [Qemu-devel] [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-07 Thread MORITA Kazutaka
At Fri, 4 Jun 2010 16:35:59 -0300, Miguel Di Ciurcio Filho wrote: > > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted an

[Qemu-devel] [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Miguel Di Ciurcio Filho
Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. First issue: Their names implies different porpouses, but they do the same thing and have exactly the same code. Maybe copied and pasted and forgotten? bdrv_has_snapshot() is called in various places for actually checkin