Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-23 Thread Anthony Liguori
On 07/23/2011 07:18 PM, Jordan Justen wrote: In terms of other flash devices, I don't think it's that simple. Flash is tied to the mobo layout so I don't think index> 0 really makes sense unless you allow a specific mapping address. I doubt that's terribly useful. I think VM's have a differe

Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-23 Thread Jordan Justen
On Sat, Jul 23, 2011 at 15:26, Anthony Liguori wrote: > On 07/23/2011 05:06 PM, Jordan Justen wrote: >> >> On Sat, Jul 23, 2011 at 14:25, Anthony Liguori >>  wrote: >>> >>> On 07/23/2011 03:19 PM, Jordan Justen wrote: On Sat, Jul 23, 2011 at 08:51, Anthony Liguori  wrote: >

Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-23 Thread Anthony Liguori
On 07/23/2011 05:06 PM, Jordan Justen wrote: On Sat, Jul 23, 2011 at 14:25, Anthony Liguori wrote: On 07/23/2011 03:19 PM, Jordan Justen wrote: On Sat, Jul 23, 2011 at 08:51, Anthony Liguori wrote: On 07/08/2011 02:37 PM, Jordan Justen wrote: If -pflash is specified and -bios is specifi

Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-23 Thread Jordan Justen
On Sat, Jul 23, 2011 at 14:25, Anthony Liguori wrote: > On 07/23/2011 03:19 PM, Jordan Justen wrote: >> >> On Sat, Jul 23, 2011 at 08:51, Anthony Liguori >>  wrote: >>> >>> On 07/08/2011 02:37 PM, Jordan Justen wrote: If -pflash is specified and -bios is specified then pflash will b

Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-23 Thread Anthony Liguori
On 07/23/2011 03:19 PM, Jordan Justen wrote: On Sat, Jul 23, 2011 at 08:51, Anthony Liguori wrote: On 07/08/2011 02:37 PM, Jordan Justen wrote: If -pflash is specified and -bios is specified then pflash will be mapped just below the system rom using hw/pflash_cfi01.c. If -pflash is specified

Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-23 Thread Jordan Justen
On Sat, Jul 23, 2011 at 08:51, Anthony Liguori wrote: > On 07/08/2011 02:37 PM, Jordan Justen wrote: >> >> If -pflash is specified and -bios is specified then pflash will >> be mapped just below the system rom using hw/pflash_cfi01.c. >> >> If -pflash is specified on the command line, but -bios is

Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-23 Thread Anthony Liguori
On 07/08/2011 02:37 PM, Jordan Justen wrote: If -pflash is specified and -bios is specified then pflash will be mapped just below the system rom using hw/pflash_cfi01.c. If -pflash is specified on the command line, but -bios is not specified, then 'bios.bin' will NOT be loaded, and instead the -

Re: [Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-15 Thread Jordan Justen
Hi all, Are there any concerns with this patch? I haven't heard much feedback, except: * Jes Sorensen - March 28 - code style * Aurelien Jarno - April 18 - Reviewed-by Thanks, -Jordan On Fri, Jul 8, 2011 at 12:37, Jordan Justen wrote: > If -pflash is specified and -bios is specified then pfla

[Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-08 Thread Jordan Justen
If -pflash is specified and -bios is specified then pflash will be mapped just below the system rom using hw/pflash_cfi01.c. If -pflash is specified on the command line, but -bios is not specified, then 'bios.bin' will NOT be loaded, and instead the -pflash flash image will be mapped just below 4G