Re: [Qemu-devel] [PATCH v4] fpu: add mechanism to check for invalid long double formats

2016-08-17 Thread Peter Maydell
On 17 August 2016 at 01:06, Andrew Dutcher wrote: > Also- I'm having issues applying the new patch: > > @@ -5768,7 +5774,9 @@ int floatx80_lt(floatx80 a, floatx80 b, > float_status *status) > > **/ > int floatx80_unorde

Re: [Qemu-devel] [PATCH v4] fpu: add mechanism to check for invalid long double formats

2016-08-16 Thread Andrew Dutcher
Also- I'm having issues applying the new patch: @@ -5768,7 +5774,9 @@ int floatx80_lt(floatx80 a, floatx80 b, float_status *status) **/ int floatx80_unordered(floatx80 a, floatx80 b, float_status *status) { -if (

Re: [Qemu-devel] [PATCH v4] fpu: add mechanism to check for invalid long double formats

2016-08-16 Thread Andrew Dutcher
I explicitly left the check off the comparison operations because I misread the NaN check as something equivalent to the check I would be adding. I'll add it shortly. With regards to adding int32_indefinite, etc constants, I think I'll leave it as is -- I'd prefer to have *what* happens clear (ret

Re: [Qemu-devel] [PATCH v4] fpu: add mechanism to check for invalid long double formats

2016-08-16 Thread Peter Maydell
On 15 August 2016 at 23:27, Andrew Dutcher wrote: > All operations that take a floatx80 as an operand need to have their > inputs checked for malformed encodings. In all of these cases, use the > function floatx80_invalid_encoding to perform the check. If an invalid > operand is found, raise an in

[Qemu-devel] [PATCH v4] fpu: add mechanism to check for invalid long double formats

2016-08-15 Thread Andrew Dutcher
All operations that take a floatx80 as an operand need to have their inputs checked for malformed encodings. In all of these cases, use the function floatx80_invalid_encoding to perform the check. If an invalid operand is found, raise an invalid operation exception, and then return either NaN (for