Peter Maydell writes:
> On 11 June 2018 at 08:56, Markus Armbruster wrote:
>> You're not printing $strchrnul like we print other configuration
>> results. Hmm, we're not printing several of them. Question for
>> maintainers (MAINTAINERS doesn't have any, so I'm cc'ing the top three
>> coughed
Keno Fischer writes:
>> Suggest return strchrnul("Hello World", 'W') != 6, to avoid worries
>> about a sufficiently smart compilers optimizing out a call that would
>> otherwise fail to link, say because headers don't match libraries.
>
> I'm happy to do that, but then again, a sufficiently smart
> Suggest return strchrnul("Hello World", 'W') != 6, to avoid worries
> about a sufficiently smart compilers optimizing out a call that would
> otherwise fail to link, say because headers don't match libraries.
I'm happy to do that, but then again, a sufficiently smart compiler might
constant fold
On 11 June 2018 at 10:38, Daniel P. Berrangé wrote:
> On Mon, Jun 11, 2018 at 09:52:55AM +0100, Peter Maydell wrote:
>> There's an argument that we should also log every config check
>> result somehow (I think autoconf configures do this), but I
>> don't think that our 'print stuff to stdout' is t
On Mon, Jun 11, 2018 at 09:52:55AM +0100, Peter Maydell wrote:
> On 11 June 2018 at 08:56, Markus Armbruster wrote:
> > You're not printing $strchrnul like we print other configuration
> > results. Hmm, we're not printing several of them. Question for
> > maintainers (MAINTAINERS doesn't have an
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On 11 June 2018 at 08:56, Markus Armbruster wrote:
> > You're not printing $strchrnul like we print other configuration
> > results. Hmm, we're not printing several of them. Question for
> > maintainers (MAINTAINERS doesn't have any, so I'm cc'
On 11 June 2018 at 08:56, Markus Armbruster wrote:
> You're not printing $strchrnul like we print other configuration
> results. Hmm, we're not printing several of them. Question for
> maintainers (MAINTAINERS doesn't have any, so I'm cc'ing the top three
> coughed up by get_maintainer.pl): bug
Keno Fischer writes:
> strchrnul is a GNU extension and thus unavailable on a number of targets.
> In the review for a commit removing strchrnul from 9p, I was asked to
> create a qemu_strchrnul helper to factor out this functionality.
> Do so, and use it in a number of other places in the code b
strchrnul is a GNU extension and thus unavailable on a number of targets.
In the review for a commit removing strchrnul from 9p, I was asked to
create a qemu_strchrnul helper to factor out this functionality.
Do so, and use it in a number of other places in the code base that inlined
the replacemen
