Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-09 Thread Stefan Hajnoczi
On Tue, Apr 09, 2013 at 08:30:44AM +0100, Richard W.M. Jones wrote: > On Mon, Apr 08, 2013 at 10:21:44PM +0200, Stefan Hajnoczi wrote: > > On Mon, Apr 8, 2013 at 4:58 PM, Stefan Hajnoczi wrote: > > > On Mon, Apr 8, 2013 at 3:05 PM, Richard W.M. Jones > > > wrote: > > > From what I can see libssh

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-09 Thread Richard W.M. Jones
On Mon, Apr 08, 2013 at 10:21:44PM +0200, Stefan Hajnoczi wrote: > On Mon, Apr 8, 2013 at 4:58 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 8, 2013 at 3:05 PM, Richard W.M. Jones > > wrote: > > From what I can see libssh2 does not support loading .ssh/config. > > I was told that sshfs *does* hand

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-08 Thread Stefan Hajnoczi
On Mon, Apr 8, 2013 at 4:58 PM, Stefan Hajnoczi wrote: > On Mon, Apr 8, 2013 at 3:05 PM, Richard W.M. Jones wrote: > From what I can see libssh2 does not support loading .ssh/config. I was told that sshfs *does* handle .ssh/config. Turns out that sshfs spawns "ssh -s sftp" to get a SFTP subsyst

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-08 Thread Stefan Hajnoczi
On Mon, Apr 8, 2013 at 3:05 PM, Richard W.M. Jones wrote: > More specifically, here's the output on my machine: > > rjones@choo:~/d/qemu/tests/qemu-iotests$ > QEMU_PROG=~/d/qemu/x86_64-softmmu/qemu-system-x86_64 PATH=~/d/qemu:$PATH > ./check -ssh gah, I just hit a libssh2 limitation. In my .ss

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-08 Thread Richard W.M. Jones
More specifically, here's the output on my machine: rjones@choo:~/d/qemu/tests/qemu-iotests$ QEMU_PROG=~/d/qemu/x86_64-softmmu/qemu-system-x86_64 PATH=~/d/qemu:$PATH ./check -ssh QEMU -- /home/rjones/d/qemu/x86_64-softmmu/qemu-system-x86_64 QEMU_IMG -- /home/rjones/d/qemu/qemu-img

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-08 Thread Richard W.M. Jones
On Mon, Apr 08, 2013 at 01:37:28PM +0200, Stefan Hajnoczi wrote: > Just ./check -nbd and ./check -ssh should work. Both work 100% for me (with patch v7). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fe

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-08 Thread Stefan Hajnoczi
On Wed, Apr 03, 2013 at 11:14:30PM +0100, Richard W.M. Jones wrote: > On Thu, Mar 28, 2013 at 11:47:32AM +0100, Stefan Hajnoczi wrote: > > On Wed, Mar 27, 2013 at 03:57:29PM +, Richard W.M. Jones wrote: > > Please run qemu-iotests, see tests/qemu-iotests/check. For example, > > with NBD: > >

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-04-03 Thread Richard W.M. Jones
On Thu, Mar 28, 2013 at 11:47:32AM +0100, Stefan Hajnoczi wrote: > On Wed, Mar 27, 2013 at 03:57:29PM +, Richard W.M. Jones wrote: [...] Thanks for reviewing this patch. I will post an updated v5 on this list soon, but I also have some comments (below). > Please run qemu-iotests, see tests/q

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-03-28 Thread Stefan Hajnoczi
On Thu, Mar 28, 2013 at 11:16:58AM +, Richard W.M. Jones wrote: > On Thu, Mar 28, 2013 at 11:47:32AM +0100, Stefan Hajnoczi wrote: > > ssh(1) prompts the user to accept the hostkey. When QEMU fails like > > this the user needs to run ssh(1) first to populate known_hosts? > > Yes - I tested th

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-03-28 Thread Richard W.M. Jones
On Thu, Mar 28, 2013 at 11:47:32AM +0100, Stefan Hajnoczi wrote: > ssh(1) prompts the user to accept the hostkey. When QEMU fails like > this the user needs to run ssh(1) first to populate known_hosts? Yes - I tested this and qemu will simply fail to open the disk with the error message about the

Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-03-28 Thread Stefan Hajnoczi
On Wed, Mar 27, 2013 at 03:57:29PM +, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > qemu-system-x86_64 -drive file=ssh://hostname/some/image > > QEMU will ssh into 'hostname' and open '/some/image' which is made > available as a standard block device. > > You can specify a us

[Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-03-27 Thread Richard W.M. Jones
From: "Richard W.M. Jones" qemu-system-x86_64 -drive file=ssh://hostname/some/image QEMU will ssh into 'hostname' and open '/some/image' which is made available as a standard block device. You can specify a username (ssh://user@host/...) and/or a port number (ssh://host:port/...). You can al

[Qemu-devel] [PATCH v4] block: Add support for Secure Shell (ssh) block device.

2013-03-27 Thread Richard W.M. Jones
This is version 4 of the Secure Shell (ssh) block device. Links to earlier versions: v1: http://www.mail-archive.com/qemu-devel@nongnu.org/msg162605.html v2: http://www.mail-archive.com/qemu-devel@nongnu.org/msg162730.html v3: http://www.mail-archive.com/qemu-devel@nongnu.org/msg162805.html The