Re: [Qemu-devel] [PATCH v3 8/9] qga: process_event() simplification

2018-08-28 Thread Michael Roth
Quoting Marc-André Lureau (2018-08-28 06:56:51) > Hi > On Tue, Aug 28, 2018 at 2:05 AM Michael Roth > wrote: > > > > Quoting Marc-André Lureau (2018-08-25 08:57:23) > > > Simplify the code around qmp_dispatch(): > > > - rely on qmp_dispatch/check_obj() for message checking > > > - have a single s

Re: [Qemu-devel] [PATCH v3 8/9] qga: process_event() simplification

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 2:05 AM Michael Roth wrote: > > Quoting Marc-André Lureau (2018-08-25 08:57:23) > > Simplify the code around qmp_dispatch(): > > - rely on qmp_dispatch/check_obj() for message checking > > - have a single send_response() point > > - constify send_response() argument > >

Re: [Qemu-devel] [PATCH v3 8/9] qga: process_event() simplification

2018-08-27 Thread Michael Roth
Quoting Marc-André Lureau (2018-08-25 08:57:23) > Simplify the code around qmp_dispatch(): > - rely on qmp_dispatch/check_obj() for message checking > - have a single send_response() point > - constify send_response() argument > > It changes a couple of error messages: > > * When @req isn't a dic

[Qemu-devel] [PATCH v3 8/9] qga: process_event() simplification

2018-08-25 Thread Marc-André Lureau
Simplify the code around qmp_dispatch(): - rely on qmp_dispatch/check_obj() for message checking - have a single send_response() point - constify send_response() argument It changes a couple of error messages: * When @req isn't a dictionary, from Invalid JSON syntax to QMP input must be