> On 11 Oct 2016, at 6:35, Cao jin wrote:
>
>
>
>> On 10/06/2016 05:39 PM, Dmitry Fleytman wrote:
>>
>
>>
>> Hello,
>>
>> Yes, from what I see, this call is wrong and leads to
>> reference leaks on device unload at migration target.
>> It should be removed.
>>
>> Best regards,
>> Dmitry
>
On 10/06/2016 05:39 PM, Dmitry Fleytman wrote:
Hello,
Yes, from what I see, this call is wrong and leads to
reference leaks on device unload at migration target.
It should be removed.
Best regards,
Dmitry
Hi,Dmitry
From what I saw, current code will call msix_vector_use twice on
> On 6 Oct 2016, at 17:43, Dr. David Alan Gilbert wrote:
>
> * Dmitry Fleytman (dmi...@daynix.com) wrote:
>>
>>> On 30 Sep 2016, at 15:08 PM, Markus Armbruster wrote:
>>>
>>> Cao jin writes:
>>>
> On 09/29/2016 10:42 PM, Markus Armbruster wrote:
> Cao jin writes:
>
>
* Dmitry Fleytman (dmi...@daynix.com) wrote:
>
> > On 30 Sep 2016, at 15:08 PM, Markus Armbruster wrote:
> >
> > Cao jin writes:
> >
> >> On 09/29/2016 10:42 PM, Markus Armbruster wrote:
> >>> Cao jin writes:
> >>>
> >>
> static int vmxnet3_post_load(void *opaque, int version_id)
> >>
> On 30 Sep 2016, at 15:08 PM, Markus Armbruster wrote:
>
> Cao jin writes:
>
>> On 09/29/2016 10:42 PM, Markus Armbruster wrote:
>>> Cao jin writes:
>>>
>>
static int vmxnet3_post_load(void *opaque, int version_id)
{
VMXNET3State *s = opaque;
-PCIDevice *d =
Cao jin writes:
> On 09/29/2016 10:42 PM, Markus Armbruster wrote:
>> Cao jin writes:
>>
>
>>> static int vmxnet3_post_load(void *opaque, int version_id)
>>> {
>>> VMXNET3State *s = opaque;
>>> -PCIDevice *d = PCI_DEVICE(s);
>>>
>>> net_tx_pkt_init(&s->tx_pkt, PCI_DEVICE(s),
On 09/29/2016 10:42 PM, Markus Armbruster wrote:
Cao jin writes:
static int vmxnet3_post_load(void *opaque, int version_id)
{
VMXNET3State *s = opaque;
-PCIDevice *d = PCI_DEVICE(s);
net_tx_pkt_init(&s->tx_pkt, PCI_DEVICE(s),
s->max_tx_frags, s->p
Cao jin writes:
> The corresponding msi flag is already dropped in commit 1070048e.
Repeating the rationale for the change wouldn't hurt:
Internal flag msix_used is unnecessary, it has the same effect as
msix_enabled().
The corresponding msi flag is already dropped in commit 107004
The corresponding msi flag is already dropped in commit 1070048e.
CC: Dmitry Fleytman
CC: Jason Wang
CC: Michael S. Tsirkin
CC: Markus Armbruster
CC: Marcel Apfelbaum
Signed-off-by: Cao jin
---
hw/net/vmxnet3.c | 38 ++
1 file changed, 14 insertions(+), 2
