Re: [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine

2012-01-13 Thread Jan Kiszka
On 2012-01-13 17:23, Alexander Graf wrote: > > On 13.01.2012, at 17:08, Jan Kiszka wrote: > >> On 2012-01-13 16:57, Andreas Färber wrote: >>> Am 13.01.2012 10:21, schrieb Jan Kiszka: On 2012-01-13 04:09, Andreas Färber wrote: > +isa_bus = DO_UPCAST(ISABus, qbus, qdev_get_child_bus(&p

Re: [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine

2012-01-13 Thread Alexander Graf
On 13.01.2012, at 17:08, Jan Kiszka wrote: > On 2012-01-13 16:57, Andreas Färber wrote: >> Am 13.01.2012 10:21, schrieb Jan Kiszka: >>> On 2012-01-13 04:09, Andreas Färber wrote: +isa_bus = DO_UPCAST(ISABus, qbus, qdev_get_child_bus(&pci->qdev, "isa.0")); + +i8259 = i

Re: [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine

2012-01-13 Thread Jan Kiszka
On 2012-01-13 16:57, Andreas Färber wrote: > Am 13.01.2012 10:21, schrieb Jan Kiszka: >> On 2012-01-13 04:09, Andreas Färber wrote: >>> +isa_bus = DO_UPCAST(ISABus, qbus, qdev_get_child_bus(&pci->qdev, >>> "isa.0")); >>> + >>> +i8259 = isa_bus->irqs; >> >> I think this is unneeded. > > Th

Re: [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine

2012-01-13 Thread Andreas Färber
Am 13.01.2012 10:21, schrieb Jan Kiszka: > On 2012-01-13 04:09, Andreas Färber wrote: >> +isa_bus = DO_UPCAST(ISABus, qbus, qdev_get_child_bus(&pci->qdev, >> "isa.0")); >> + >> +i8259 = isa_bus->irqs; > > I think this is unneeded. The problem here was that isa_get_irq() needs an ISADevic

Re: [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine

2012-01-13 Thread Jan Kiszka
On 2012-01-13 04:09, Andreas Färber wrote: > Speaker I/O, ISA bus, i8259 PIC, RTC and DMA are no longer set up > individually by the machine. Effectively, no-op speaker I/O is replaced > by pcspk; PIT and i82374 DMA are introduced. > > Signed-off-by: Hervé Poussineau > > Remove related dead, alt

[Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine

2012-01-12 Thread Andreas Färber
Speaker I/O, ISA bus, i8259 PIC, RTC and DMA are no longer set up individually by the machine. Effectively, no-op speaker I/O is replaced by pcspk; PIT and i82374 DMA are introduced. Signed-off-by: Hervé Poussineau Remove related dead, alternative code. Access i8259 IRQs via ISA bus to resolve c