Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

2017-06-22 Thread Paolo Bonzini
- Original Message - > From: "Thomas Huth" > To: "Richard Henderson" , qemu-devel@nongnu.org, "Paolo > Bonzini" > Sent: Wednesday, June 21, 2017 3:40:31 AM > Subject: Re: [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common > object > > On 20.06.2017 20:14, Richard Henderson

Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

2017-06-20 Thread Thomas Huth
On 20.06.2017 20:14, Richard Henderson wrote: > On 06/19/2017 10:52 PM, Thomas Huth wrote: >> edu.c does not contain any target-specific code, so we can put >> it into common-obj-y to compile it only once for all targets. >> >> Signed-off-by: Thomas Huth > > Isn't CONFIG_EDU defined by the target

Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

2017-06-20 Thread Richard Henderson
On 06/19/2017 10:52 PM, Thomas Huth wrote: edu.c does not contain any target-specific code, so we can put it into common-obj-y to compile it only once for all targets. Signed-off-by: Thomas Huth Isn't CONFIG_EDU defined by the target, via pci.conf? Would it ever be set generically? r~

[Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

2017-06-19 Thread Thomas Huth
edu.c does not contain any target-specific code, so we can put it into common-obj-y to compile it only once for all targets. Signed-off-by: Thomas Huth --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs inde