Re: [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 16:04:52 +0200]: > Simplify the error handling of the HSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 18 +- >

Re: [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler

2017-10-18 Thread Thomas Huth
On 17.10.2017 16:04, Halil Pasic wrote: > Simplify the error handling of the HSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 18 +- > inc

Re: [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler

2017-10-17 Thread Cornelia Huck
On Tue, 17 Oct 2017 16:04:52 +0200 Halil Pasic wrote: > Simplify the error handling of the HSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 18 +

[Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler

2017-10-17 Thread Halil Pasic
Simplify the error handling of the HSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 18 +- include/hw/s390x/css.h | 2 +- target/s390x/ioinst.c | 23