Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-15 Thread Jason Wang
On 12/15/2015 02:09 PM, Shmulik Ladkani wrote: > Hi Jason, > > On Tue, 15 Dec 2015 10:35:59 +0800 Jason Wang wrote: >>> Another attempt I've made is to indroduce a new type vmxnet3e (the >>> pcie variant of vmxnet3). >>> I dropped this approach since it was way too cumbersome, introducing >>> lo

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-14 Thread Shmulik Ladkani
Hi Jason, On Tue, 15 Dec 2015 10:35:59 +0800 Jason Wang wrote: > > Another attempt I've made is to indroduce a new type vmxnet3e (the > > pcie variant of vmxnet3). > > I dropped this approach since it was way too cumbersome, introducing > > lots of boiler-plate code for the two (otherwise) identi

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-14 Thread Jason Wang
On 12/14/2015 03:32 PM, Shmulik Ladkani wrote: > Thanks Jason, > > On Mon, 14 Dec 2015 14:24:36 +0800, jasow...@redhat.com wrote: >>> +static void vmxnet3_realize(DeviceState *qdev, Error **errp) >>> +{ >>> +VMXNET3Class *vc = VMXNET3_DEVICE_GET_CLASS(qdev); >>> +PCIDevice *pci_dev = PCI_

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-13 Thread Shmulik Ladkani
Thanks Jason, On Mon, 14 Dec 2015 14:24:36 +0800, jasow...@redhat.com wrote: > > +static void vmxnet3_realize(DeviceState *qdev, Error **errp) > > +{ > > +VMXNET3Class *vc = VMXNET3_DEVICE_GET_CLASS(qdev); > > +PCIDevice *pci_dev = PCI_DEVICE(qdev); > > +VMXNET3State *s = VMXNET3(qdev)

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-13 Thread Jason Wang
On 12/12/2015 08:00 PM, Shmulik Ladkani wrote: > Report the 'express endpoint' capability if on a PCIE bus. > > Signed-off-by: Shmulik Ladkani > --- > hw/net/vmxnet3.c | 53 - > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git a/

[Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-12 Thread Shmulik Ladkani
Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 14d4dcb..7ded287 1006