Re: [Qemu-devel] [PATCH v3 4/8] xics: minor changes and cleanups

2013-08-26 Thread Alexander Graf
On 26.08.2013, at 16:20, Andreas Färber wrote: > Am 26.08.2013 15:36, schrieb Alexander Graf: >> >> On 19.08.2013, at 07:55, Alexey Kardashevskiy wrote: >> >>> Before XICS-KVM comes, it makes sense to clean up the emulated XICS a bit. >>> >>> This does: >>> 1. add assert in ics_realize() >>> 2

Re: [Qemu-devel] [PATCH v3 4/8] xics: minor changes and cleanups

2013-08-26 Thread Andreas Färber
Am 26.08.2013 15:36, schrieb Alexander Graf: > > On 19.08.2013, at 07:55, Alexey Kardashevskiy wrote: > >> Before XICS-KVM comes, it makes sense to clean up the emulated XICS a bit. >> >> This does: >> 1. add assert in ics_realize() >> 2. change variable names from "k" to more informative ones >>

Re: [Qemu-devel] [PATCH v3 4/8] xics: minor changes and cleanups

2013-08-26 Thread Alexander Graf
On 19.08.2013, at 07:55, Alexey Kardashevskiy wrote: > Before XICS-KVM comes, it makes sense to clean up the emulated XICS a bit. > > This does: > 1. add assert in ics_realize() > 2. change variable names from "k" to more informative ones > 3. add "const" to every TypeInfo > 4. replace fprintf(s

[Qemu-devel] [PATCH v3 4/8] xics: minor changes and cleanups

2013-08-18 Thread Alexey Kardashevskiy
Before XICS-KVM comes, it makes sense to clean up the emulated XICS a bit. This does: 1. add assert in ics_realize() 2. change variable names from "k" to more informative ones 3. add "const" to every TypeInfo 4. replace fprintf(stderr, ..."\n") with error_report 5. replace old style qdev_init_nofa