Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-28 Thread Laszlo Ersek
On 10/28/15 02:12, Gabriel L. Somlo wrote: > On Tue, Oct 27, 2015 at 01:43:39PM +0100, Laszlo Ersek wrote: >> On 10/27/15 12:11, Gerd Hoffmann wrote: >>> Hi, >>> > My hypothesis (which I guess I'm volunteering to verify, unless we > end up rejecting this immediately as a bad idea, for som

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-27 Thread Gabriel L. Somlo
On Tue, Oct 27, 2015 at 01:43:39PM +0100, Laszlo Ersek wrote: > On 10/27/15 12:11, Gerd Hoffmann wrote: > > Hi, > > > >>> My hypothesis (which I guess I'm volunteering to verify, unless we > >>> end up rejecting this immediately as a bad idea, for some reason that > >>> I have missed), is that c

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-27 Thread Laszlo Ersek
On 10/27/15 12:11, Gerd Hoffmann wrote: > Hi, > >>> My hypothesis (which I guess I'm volunteering to verify, unless we >>> end up rejecting this immediately as a bad idea, for some reason that >>> I have missed), is that current functionality wouldn't change, given >>> the way existing callbacks

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-27 Thread Gerd Hoffmann
Hi, > > My hypothesis (which I guess I'm volunteering to verify, unless we > > end up rejecting this immediately as a bad idea, for some reason that > > I have missed), is that current functionality wouldn't change, given > > the way existing callbacks work right now, and that we could run the >

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-26 Thread Gabriel L. Somlo
On Mon, Oct 26, 2015 at 02:38:11PM +0100, Laszlo Ersek wrote: > On 10/26/15 13:49, Gabriel L. Somlo wrote: > > On Mon, Oct 26, 2015 at 10:48:08AM +, Stefan Hajnoczi wrote: > >> On Thu, Oct 22, 2015 at 05:22:16PM -0400, Gabriel L. Somlo wrote: > >>> I was re-reading the documentation for fw_cfg_

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-26 Thread Laszlo Ersek
On 10/26/15 13:49, Gabriel L. Somlo wrote: > On Mon, Oct 26, 2015 at 10:48:08AM +, Stefan Hajnoczi wrote: >> On Thu, Oct 22, 2015 at 05:22:16PM -0400, Gabriel L. Somlo wrote: >>> I was re-reading the documentation for fw_cfg_add_file_callback(), >>> and noticed that non-dma read operations chec

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-26 Thread Gabriel L. Somlo
On Mon, Oct 26, 2015 at 10:48:08AM +, Stefan Hajnoczi wrote: > On Thu, Oct 22, 2015 at 05:22:16PM -0400, Gabriel L. Somlo wrote: > > I was re-reading the documentation for fw_cfg_add_file_callback(), > > and noticed that non-dma read operations check for the presence > > of a callback (and call

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-26 Thread Stefan Hajnoczi
On Thu, Oct 22, 2015 at 05:22:16PM -0400, Gabriel L. Somlo wrote: > I was re-reading the documentation for fw_cfg_add_file_callback(), > and noticed that non-dma read operations check for the presence > of a callback (and call it if present) for *every* *single* *byte*, > even on 64-bit MMIO reads.

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-22 Thread Gabriel L. Somlo
On Sat, 19 Sep 2015, Laszlo Ersek wrote: > Got some good news: with those two fixups in place (register block > size corrected, and dma_enabled set via device property), I could > test the AAVMF / ArmVirtPkg / > patches. > > On my APM Mustang, downloading a decompressed kernel (14,475,776 > bytes)

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-19 Thread Marc Marí
On Sat, 19 Sep 2015 01:10:46 +0200 Laszlo Ersek wrote: > On 09/18/15 22:24, Marc Marí wrote: > > On Fri, 18 Sep 2015 22:16:46 +0200 > > Laszlo Ersek wrote: > > > >> On 09/18/15 10:58, Marc Marí wrote: > >>> Enable the fw_cfg DMA interface for the ARM virt machine. > >>> > >>> Based on Gerd Hoff

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 22:24, Marc Marí wrote: > On Fri, 18 Sep 2015 22:16:46 +0200 > Laszlo Ersek wrote: > >> On 09/18/15 10:58, Marc Marí wrote: >>> Enable the fw_cfg DMA interface for the ARM virt machine. >>> >>> Based on Gerd Hoffman's initial implementation. >>> >>> Signed-off-by: Marc Marí >>> --- >

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Marc Marí
On Fri, 18 Sep 2015 22:16:46 +0200 Laszlo Ersek wrote: > On 09/18/15 10:58, Marc Marí wrote: > > Enable the fw_cfg DMA interface for the ARM virt machine. > > > > Based on Gerd Hoffman's initial implementation. > > > > Signed-off-by: Marc Marí > > --- > > hw/arm/virt.c | 9 + > > 1 fi

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 10:58, Marc Marí wrote: > Enable the fw_cfg DMA interface for the ARM virt machine. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/virt.c

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 10:58, Marc Marí wrote: > Enable the fw_cfg DMA interface for the ARM virt machine. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/virt.c

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 09:58, Marc Marí wrote: > Enable the fw_cfg DMA interface for the ARM virt machine. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/

[Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/arm/virt.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 3568107..47f4ad3 100644 --- a/hw/