Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-25 Thread Igor Mammedov
On Tue, 24 Feb 2015 15:19:28 -0300 Eduardo Habkost wrote: > On Tue, Feb 24, 2015 at 09:01:04AM +0100, Igor Mammedov wrote: > > On Thu, 12 Feb 2015 15:50:35 -0200 > > Eduardo Habkost wrote: > > > > > Instead of silently assigning CPU to node 0 when it is omitted from the > > > command-line, chec

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-24 Thread Eduardo Habkost
On Tue, Feb 24, 2015 at 09:01:04AM +0100, Igor Mammedov wrote: > On Thu, 12 Feb 2015 15:50:35 -0200 > Eduardo Habkost wrote: > > > Instead of silently assigning CPU to node 0 when it is omitted from the > > command-line, check if all CPUs up to max_cpus are present in the NUMA > > configuration.

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-24 Thread Igor Mammedov
On Thu, 12 Feb 2015 15:50:35 -0200 Eduardo Habkost wrote: > Instead of silently assigning CPU to node 0 when it is omitted from the > command-line, check if all CPUs up to max_cpus are present in the NUMA > configuration. That would also trigger warning for possible (i.e. to be hotplugged) CPUs a

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-12 Thread Eduardo Habkost
On Thu, Feb 12, 2015 at 07:22:37PM +0100, Paolo Bonzini wrote: > On 12/02/2015 18:50, Eduardo Habkost wrote: > > + > > +if (!bitmap_full(seen_cpus, max_cpus)) { > > +char *msg; > > +bitmap_complement(seen_cpus, seen_cpus, max_cpus); > > +msg = enumerate_cpus(seen_cpus, m

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 18:50, Eduardo Habkost wrote: > + > +if (!bitmap_full(seen_cpus, max_cpus)) { > +char *msg; > +bitmap_complement(seen_cpus, seen_cpus, max_cpus); > +msg = enumerate_cpus(seen_cpus, max_cpus); > +error_report("warning: CPU(s) not present in any NUM

[Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-12 Thread Eduardo Habkost
Instead of silently assigning CPU to node 0 when it is omitted from the command-line, check if all CPUs up to max_cpus are present in the NUMA configuration. I am making this a warning and not a fatal error, to allow management software to be updated if necessary. Signed-off-by: Eduardo Habkost