Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-20 Thread
OK. Thx Andreas! 在2013年12月20日 19:18, Andreas Färber写道: Am 19.12.2013 15:20, schrieb Paolo Bonzini: > Il 18/12/2013 19:03, Andreas Färber ha scritto: @@ -61,7 +69,6 @@ static void ioapic_common_realize(DeviceState *dev, Error **errp)  {      IOAPICCommonState *s = IOAPIC_COMMON(dev

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-20 Thread Andreas Färber
Am 19.12.2013 15:20, schrieb Paolo Bonzini: > Il 18/12/2013 19:03, Andreas Färber ha scritto: @@ -61,7 +69,6 @@ static void ioapic_common_realize(DeviceState *dev, Error **errp) { IOAPICCommonState *s = IOAPIC_COMMON(dev); IOAPICCommonClass *info; -stat

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-19 Thread Paolo Bonzini
Il 18/12/2013 19:03, Andreas Färber ha scritto: >> > @@ -61,7 +69,6 @@ static void ioapic_common_realize(DeviceState *dev, >> > Error **errp) >> > { >> > IOAPICCommonState *s = IOAPIC_COMMON(dev); >> > IOAPICCommonClass *info; >> > -static int ioapic_no; >> > >> > if (ioapic_

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-18 Thread 赵小强
于 12/19/2013 02:03 AM, Andreas Färber 写道: Am 05.11.2013 11:16, schrieb xiaoqiang zhao: changes: 1. use type constant for kvm_ioapic and ioapic 2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic For QOM'ify, I move variable 'ioapic_no' from static to global. Then we can drop the 'inst

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-18 Thread 赵小强
于 12/19/2013 10:28 AM, Chen Fan 写道: On Wed, 2013-12-18 at 19:03 +0100, Andreas Färber wrote: Am 05.11.2013 11:16, schrieb xiaoqiang zhao: changes: 1. use type constant for kvm_ioapic and ioapic 2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic For QOM'ify, I move variable 'ioapic_n

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-18 Thread Chen Fan
On Wed, 2013-12-18 at 19:03 +0100, Andreas Färber wrote: > Am 05.11.2013 11:16, schrieb xiaoqiang zhao: > > changes: > > 1. use type constant for kvm_ioapic and ioapic > > 2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic > > For QOM'ify, I move variable 'ioapic_no' from static to glob

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-18 Thread Andreas Färber
Am 05.11.2013 11:16, schrieb xiaoqiang zhao: > changes: > 1. use type constant for kvm_ioapic and ioapic > 2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic > For QOM'ify, I move variable 'ioapic_no' from static to global. > Then we can drop the 'instance_no' argument. Now, it's child

[Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-11-05 Thread xiaoqiang zhao
changes: 1. use type constant for kvm_ioapic and ioapic 2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic For QOM'ify, I move variable 'ioapic_no' from static to global. Then we can drop the 'instance_no' argument. Now, it's child that increase 'ioapic_no' counter. Signed-off-by: xiao