Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 05:31 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 05:03:56PM -0400, Cleber Rosa wrote: >> On 05/30/2018 04:00 PM, Eduardo Habkost wrote: > [...] >> [...] Now, in addition to this very personal, and thus >> insignificant botheration, it restricts API design. By sig

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 05:03:56PM -0400, Cleber Rosa wrote: > On 05/30/2018 04:00 PM, Eduardo Habkost wrote: [...] > [...] Now, in addition to this very personal, and thus > insignificant botheration, it restricts API design. By signaling to > users that this is valid: > > self.vm.add_

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 04:00 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 02:00:48PM -0400, Cleber Rosa wrote: >> >> >> On 05/30/2018 12:29 PM, Eduardo Habkost wrote: >>> On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wr

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 02:00:48PM -0400, Cleber Rosa wrote: > > > On 05/30/2018 12:29 PM, Eduardo Habkost wrote: > > On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: > >> On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > >>> This patch adds a few simple behavior test

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 12:29 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: >> On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: >>> This patch adds a few simple behavior tests for VNC. >>> >>> Signed-off-by: Cleber Rosa >>> --- >>> tests/accept

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > > This patch adds a few simple behavior tests for VNC. > > > > Signed-off-by: Cleber Rosa > > --- > > tests/acceptance/vnc.py | 60 +++

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Fam Zheng
On Wed, 05/30 13:57, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > > This patch adds a few simple behavior tests for VNC. > > > > Signed-off-by: Cleber Rosa > > --- > > tests/acceptance/vnc.py | 60 + > > 1 file ch

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > This patch adds a few simple behavior tests for VNC. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/vnc.py | 60 + > 1 file changed, 60 insertions(+) > create mode 100644 tests/accept

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > This patch adds a few simple behavior tests for VNC. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/vnc.py | 60 + > 1 file changed, 60 insertions(+) > create mode 100644 tests/accept

[Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-29 Thread Cleber Rosa
This patch adds a few simple behavior tests for VNC. Signed-off-by: Cleber Rosa --- tests/acceptance/vnc.py | 60 + 1 file changed, 60 insertions(+) create mode 100644 tests/acceptance/vnc.py diff --git a/tests/acceptance/vnc.py b/tests/acceptance/vnc.py