Re: [Qemu-devel] [PATCH v3 3/4] serial: update LSR on enabling/disabling FIFOs

2014-12-15 Thread Paolo Bonzini
On 15/12/2014 16:50, Dr. David Alan Gilbert wrote: >> > >> > if (val & UART_FCR_XFR) { >> > +s->lsr |= UART_LSR_THRE; >> > +s->thr_ipending = 1; >> > fifo8_reset(&s->xmit_fifo); >> > } > Doesn't that break the assertion you added in patch 2

Re: [Qemu-devel] [PATCH v3 3/4] serial: update LSR on enabling/disabling FIFOs

2014-12-15 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > When the transmit FIFO is emptied or enabled, the transmitter > hold register is empty. When it is disabled, it is also emptied and > in addition the previous contents of the transmitter hold register > are discarded. In either case, the THRE bit in

[Qemu-devel] [PATCH v3 3/4] serial: update LSR on enabling/disabling FIFOs

2014-12-12 Thread Paolo Bonzini
When the transmit FIFO is emptied or enabled, the transmitter hold register is empty. When it is disabled, it is also emptied and in addition the previous contents of the transmitter hold register are discarded. In either case, the THRE bit in LSR must be set and THRI raised. When the receive FI